Bug 11085 - Fix and enhance rpcclient output
Fix and enhance rpcclient output
Status: RESOLVED FIXED
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Printing
unspecified
All All
: P5 enhancement
: ---
Assigned To: printing-maintainers
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-01-30 12:31 UTC by Robin Hack
Modified: 2015-03-13 09:18 UTC (History)
4 users (show)

See Also:


Attachments
Patch for rpcclient binary (2.12 KB, patch)
2015-01-30 12:31 UTC, Robin Hack
asn: review+
ddiss: review+
gd: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Hack 2015-01-30 12:31:04 UTC
Created attachment 10702 [details]
Patch for rpcclient binary

Hi samba team.

When rpcclient is called like:
$ rpcclient -c "getdata . Osversion"
at end of output is added one nonsense line
OsVersion: Osversion:

This patch removes this line and adds more human friendly ouput:
OsMajor: num
OsMinor: num
OsBuild: num

for OsVersion query.

For OsVersionEx two more lines are added:
OsMajor: num
OsMinor: num
OsBuild: num
ServicePackMajor: num
ServicePackMinor: num

I wrote patch which is attached.
If you will see some place to improvement, don't hesitate and raise your note please.

Have nice day
Robin Hack
Comment 1 Guenther Deschner 2015-01-30 13:42:11 UTC
Comment on attachment 10702 [details]
Patch for rpcclient binary

LGTM
Comment 2 Stefan Metzmacher 2015-03-13 09:18:20 UTC
Fixed in master as bcbdc74b2618bdddb920feecf3e8bd7d11f12441