The Samba-Bugzilla – Bug 11041
Uninitialised variable used to compute return value in srv_send_smb()
Last modified: 2015-01-24 20:47:16 UTC
The fix for bug 10880 changed the srv_send_smb() error path such that it returns a value depending on the value of @ret:
Author: Richard Sharpe <firstname.lastname@example.org>
Date: Mon Jul 22 16:04:43 2013 -0700
There are tests all over the SMB1 code to check that srv_send_smb fails, but it never returns false.
This change was merged to the v4-1 and v4-0 maintenance branches. A subsequent change fixed the srv_send_smb()->srv_encrypt_buffer() error path to ensure that @ret is initialised on error:
Author: Volker Lendecke <email@example.com>
Date: Sun Aug 18 20:35:32 2013 +0000
smbd: Fix CID 1063259 Uninitialized scalar variable
This change was not merged to the v4-1 and v4-0 maintenance branches, but should be given that the bug 10880 change was merged.
Created attachment 10604 [details]
fix for v4-0-test branch
Created attachment 10605 [details]
fix for v4-1-test branch
The fix went into master prior to the 4.2 branch, so no 4.2 merge is needed.
@Karolin, please merge to the 4.1 and 4.0 maintenance branches.
Pushed to autobuild-v4-[0|1]-test.
Pushed to v4-1-test and v4-0-test.
Closing out bug report.