Bug 10943 - Some more whitespace cleanups in Wireshark/NDR.pm to match what's in Wireshark Git
Summary: Some more whitespace cleanups in Wireshark/NDR.pm to match what's in Wireshar...
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: PIDL and libndr (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Jelmer Vernooij
Depends on:
Reported: 2014-11-20 01:10 UTC by Guy Harris
Modified: 2019-04-01 21:20 UTC (History)
0 users

See Also:

Patch to clean up NDR.pm (1.63 KB, patch)
2014-11-20 01:10 UTC, Guy Harris
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guy Harris 2014-11-20 01:10:51 UTC
Created attachment 10441 [details]
Patch to clean up NDR.pm

At this point, pidl/lib/Parse/Pidl/Wireshark/NDR.pm differs from the Wireshark version in only a few whitespace-related places - a couple of blank lines not in the Wireshark version, and one indentation.

Here's a patch to clean those up.  (I've also changed the Wireshark version to match the Samba version in some places.)

It also fixes a comment inserted into the generated code, fixing a typo ("filter" -> "file") and indicates that the generator was Pidl.
Comment 1 Guy Harris 2016-07-27 22:18:29 UTC
This appears to have been fixed.
Comment 2 Andrew Bartlett 2019-04-01 21:20:58 UTC
Moving PIDL bugs into Samba as we do not release PIDL separately.