Bug 10939 - samba_tool_demote test breaks environment it runs in
Summary: samba_tool_demote test breaks environment it runs in
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Test infrastructure (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jelmer Vernooij
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 10873
  Show dependency tree / graph
 
Reported: 2014-11-16 17:22 UTC by Jelmer Vernooij
Modified: 2014-11-17 11:17 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jelmer Vernooij 2014-11-16 17:22:58 UTC 
As noted in the comments in source4/selftest/tests.py:

    # Demote the vampire DC, it must currently be the last test on the VAMPIRE DC

This should not be the case, as it prevents us from running tests in random order.
Comment 1 Jelmer Vernooij 2014-11-16 17:24:42 UTC 
There are a couple of ways we can fix this:

 * mark the test as 'dirty' so that selftest.pl knows to discard the environment and set it up again from scratch
 * have samba_tool_demote do a promote after it has done the demotion