Created attachment 10426 [details] Patch There's a talloc/safe_free in pdb_tdb
Applies cleanly (with git am -3) back to v3-6-test
Pushed to autobuild-v4-[0|1|2]-test. Please note that the usual procedure is to add the patchsets including the bug number in the commit message to the bug report and add separate review flags, because the review is only valid for one branch. It might (and did) happen that a patch is valid for master, but wrong for e.g. v4-1-test although applying cleanly. Thanks!
I herewith pull back this patch. I did not want to port this back because it is not a user-reported issue. I did not follow the rules, so please stop the autobuild. Thanks, Volker
(In reply to Volker Lendecke from comment #3) > I herewith pull back this patch. I did not want to port this back because it is > not a user-reported issue. I did not follow the rules, so please stop the > autobuild. I don't understand your hesitation here. IMO this fixes an obvious bug, and the change is clearly correct. It looks like it's already made it into the maintenance branches, so I'll change the status to fix.
(In reply to Volker Lendecke from comment #3) Volker, please! Sorry for trying to avoid mistakes. Some people want me to be picky, others are offended. And no, I don't revert anything.
(In reply to David Disseldorp from comment #4) Thanks, David! The v4-0-test autobuild failed (obviously not because of this fix!). Pushed to v4-2-test and v4-1-test.