Bug 10846 - "net ads keytab create" different usage description
"net ads keytab create" different usage description
Status: NEW
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB
4.1.12
All All
: P5 normal
: ---
Assigned To: Andrew Bartlett
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-29 12:29 UTC by Noël Köthe
Modified: 2014-09-30 11:07 UTC (History)
1 user (show)

See Also:


Attachments
simple patch to make the usage the same (344 bytes, patch)
2014-09-29 12:29 UTC, Noël Köthe
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Noël Köthe 2014-09-29 12:29:43 UTC
Created attachment 10319 [details]
simple patch to make the usage the same

Hello,

the command "net ads keytab create has two usage descriptions which IMHO should be the same:

source3/utils/net_ads.c
...
static int net_ads_keytab_create(struct net_context *c, int argc, const char **argv)
{
        ADS_STRUCT *ads;
        int ret;

        if (c->display_usage) {
                d_printf(  "%s\n"
                           "net ads keytab create\n"
                           "    %s\n",
                         _("Usage:"),
                         _("Create new default keytab"));
...
                        "create",
                        net_ads_keytab_create,
                        NET_TRANSPORT_ADS,
                        N_("Create a fresh keytab"),
                        N_("net ads keytab create\n"
                           "    Create a fresh keytab")
...

With the second usage line (shown when "net ads keytab help") I was under the wrong impression it will create a keytab file and with luck the one I defined with the smb.conf option dedicated keytab file =

"Create new default keytab" is the better description because it always and only creates the default keytab (called function ads_keytab_create_default()) and the dedicated keytab file is ignored.
Comment 1 Noël Köthe 2014-09-29 12:35:50 UTC
Maybe the "dedicated keytab file" in smb.conf could get an additional note: 

"Note that this parameter is not read by net ads keytab create"

Or maybe that the "dedicated keytab file" parameter is used by "net ads keytab create".

Thank you.