Bug 10803 - nmblookup doesn't return a failure exit code if the query fails
Summary: nmblookup doesn't return a failure exit code if the query fails
Status: ASSIGNED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.0.21
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-09 07:52 UTC by Andreas Schneider
Modified: 2014-09-10 14:10 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2014-09-09 07:52:26 UTC 
nmblookup doesn't return a failure exit code if the query fails. The return code is always 0.
Comment 1 Jeremy Allison 2014-09-09 15:56:02 UTC 
So did my patch fix it ?
Comment 2 Andreas Schneider 2014-09-10 07:11:47 UTC 
Yes, it did. Sorry I forgot to reply to the mail. I had some modifications to it. I discussed it with Günther and we thought about different return values so you can find out if the query was sent bug didn't succeed or if it was a fatal failure.