The Samba-Bugzilla – Bug 10800
Array index out of bounds in smbtorture
Last modified: 2016-07-29 00:01:56 UTC
In torture/smb2/dir.c method test_modify_search an array of 702 elements is defined, which means the entries are accessible on indexes 0 to 701. Later in this method, the index 702 is used.
The patch is pretty simple: enlarge the buffer with 1.
Created attachment 10261 [details]
Created attachment 10263 [details]
Thanks, entirely correct. I'd prefer this version though to couple the array sizes. Ok?
@volker: I'm sure if you were targetting me, but in any case: I'm completely fine with using your version (I think that one is cleaner)
Comment on attachment 10263 [details]
Looks good, please push to master with reviewed-by: me
Fixed in master with abe499be569c9087f007331d3ac2e48cea0e2cae