Created attachment 10216 [details]
Don't discard result of checking grouptype
The pdb_samba_dsdb_getgrfilter() function first determines the security type
of a group and sets map->sid_name_use accordingly. A little later, this
variable is set again, undoing the previous work.
I stumbled upon this while looking for a different problem. It might be nothing, but it looked like a problem, so I thought I'd report it, in the hope that it might be useful.
Looks completely correct to me. I'll post it on samba-technical to get into master and we'll get it fixed in 4.1.x and 4.0.x from there.
Created attachment 10222 [details]
git-am fix for 4.1.next and 4.0.next.
Fix that went into master.
Looks good. Karolin, please merge.
Pushed to autobuild-v4-[0|1]-test.
Pushed to both branches.
Closing out bug report.