Bug 10750 - Let dynamic dns updates fill dwSerial correct
Summary: Let dynamic dns updates fill dwSerial correct
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: DNS server (internal) (show other bugs)
Version: 4.1.4
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Stefan Metzmacher
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-29 11:49 UTC by Stefan Metzmacher
Modified: 2021-03-03 03:20 UTC (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2014-07-29 11:49:51 UTC 
We currently have this:

        /* TODO: Autogenerate this somehow */
        r->dwSerial = 110;

which seems to be wrong.

In the rpc server we have a
dnsserver_update_soa() function which increments the searial number
on the SOA record.
Comment 1 Douglas Bagnall 2021-03-03 03:20:04 UTC 
[MS-DNSP] says "dwSerial: This MUST be set to 0x00000000 when sent by the client or server, and ignored on receipt by the server or client" and "dwFlags, dwSerial, dwTimeStamp, and dwReserved are set to zero". Except for SOA records.

Could zero be the correct autogeneration? Or is there a chance that an SOA could come through these paths and we need to handle that case?

110 is also used with despairing comments in py_dsdb_dns_replace_by_dn() and py_dsdb_dns_replace().