Any news about this when it will resolved ?

Reassigning to Amitay

Created attachment 10356 [details]
DNS patches to add support for BIND 9.10.x

Can someone test these patches with BIND 9.10.x?

The patches are for samba master.

Created attachment 10368 [details]
patches for samba-4.2

Created attachment 10369 [details]
patches for samba-4.1

As i already discussed with Amitay on IRC:

at least the the bind dlz_open driver exported functions
   "putrr" and 
   "putnamedrr"
are now more picky regarding the terminating dot at the end of (domain) names.

ATM those functions don't take care of the trailing dot!

Now for example i always get e.g.
 "li4771-131.addlz.kukkukk.com.addlz.kukkukk.com."
Note the double addition of the domain name!
After some minutes this "appending" also makes it into the samba DB storage:

samba_dlz: added rdataset _msdcs.addlz.kukkukk.com '_msdcs.addlz.kukkukk.com.  3600    IN      SOA     li4771-131.addlz.kukkukk.com. hostmaster.addlz.kukkukk.com._msdcs.addlz.kukkukk.com._msdcs.addlz.kukkukk.com._msdcs.addlz.kukkukk.com._msdcs.addlz.kukkukk.com._msdcs.addlz.kukkukk.com._msdcs.addlz.kukkukk.com._msdcs.addlz.kukkukk.com. 10 900 600 86400 3600'

... until name length errors occur.

So the current samba DLZ driver for bind-9.10.x is unusable and needs some additions.

I already prepared a patch, which seemed to fix all new problems.

But then i noticed that both
   rndc dumpdb -all
   dig AXFR zonename
still show _some_ double appending of the zone names ....

So i'm still investigating. My debugging atm shows that the DLZ driver with
my patch is now returning all names correctly to bind.

So it could also be a bind problem (with the special upper DLZ driver).

I keep you informed about my findings.

Cheers,  Günter

Created attachment 10395 [details]
Fix for bind 9.10 - add trailing .

Hi Günter,

Can you test with the attached patch?  I haven't found any problems in my testing.

Amitay.

Hi Amitay,

i've tested your patch against
  bind-9.10.1
  bind-9.9.5   (to check for a regression)
and all is working as expected.

I would modify
-	if (str == NULL) {
+	if (str == NULL || *str == '\0') {
		return str;
	}

	len = strlen(str);
	if (str[len-1] != '.') {
		tmp = talloc_asprintf(mem_ctx, "%s.", str);

otherwise str[len-1] would access out-of-range memory in case
of an empty string.

It also worries me, that the return code of many talloc_*
functions is not checked for failure (as i did in my test patch).

I treat it as a bug, when the return code of a possibly failing
function is not checked...

Otherwise you can add my

Reviewed-by: Guenter Kukkukk <kukks@samba.org>

Cheers, Günter

Created attachment 10408 [details]
Fix for bind 9.10 - add trailing .

Hi Amitay,

two notes:

1.) In my temp-patch i used:
 	 char *tmp;
+	 const char *str;

and then assigned the new fqdn-string to "str" instead of "tmp".

Your current version leads to warnings:
[2362/4226] Compiling source4/dns_server/dlz_bind9.c
../source4/dns_server/dlz_bind9.c: In function ‘b9_format’:
../source4/dns_server/dlz_bind9.c:176:7: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default]
   tmp = b9_format_fqdn(mem_ctx, rec->data.srv.nameTarget);
       ^
../source4/dns_server/dlz_bind9.c:189:7: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default]
   tmp = b9_format_fqdn(mem_ctx, rec->data.mx.nameTarget);
       ^
../source4/dns_server/dlz_bind9.c:228:7: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default]
   tmp = b9_format_fqdn(mem_ctx, rec->data.soa.rname);

So you should change that, too.
------------------

2.) Your patch contains trailing whitespace
See screencapture from emacs (the red blocks):
   http://picpaste.com/pics/emacs1-oEjdjD3L.1415229997.png

To *visually* notice those whitespace, with emacs i use:
;; set show trailing whitespace always on:
(setq-default show-trailing-whitespace t)

Also git can remove trailing whitespace:
git config --global apply.whitespace strip

Cheers, Günter

Created attachment 10446 [details]
Fix for bind 9.10 - add trailing .

Hi Günter,

I have updated the patch based on your suggestions.

Amitay.

Is the 4.1 patch likely to make it into the Samba 4.1.14 release scheduled for Dec 1st?

Hi Amitay,

now the patch looks ok.

Have done my usual tests and
  rndc dumpdb -all
  dig @server axfr zone
and also
make test TESTS=dlz_bind9
passes.

But you really should fix your editor to not produce trailing spaces.
See
http://picpaste.com/emacs2-3i40NQdI.png
the red blocks.

But will give my review answer.

Cheers, Günter

Hmm, it seems that kukks@samba.org does not work
to answer the review request. Cannot click that link.

Amitay,
remove that review request and use the following one:
linux@kukkukk.com

That one worked in the past.
Will ask Lars to have a look.

Cheers, Günter

sorry, forget the last post.  :-)

Cheers, Günter

(In reply to Guenter Kukkukk from comment #16)

I do have trailing space highlighting.  However, most of those spaces have been there for a while.  I hope I have not added new ones. :-)

Created attachment 10447 [details]
patches for samba-4.1

Created attachment 10448 [details]
patches for samba-4.2

Hi Karonlin,

Patches for 4.1 and 4.2 attached.

Amitay.

(In reply to Amitay Isaacs from comment #22)
Pushed to autobuild-v4-[1|2]-test.

(In reply to Karolin Seeger from comment #23)
Pushed to both branches.
Closing out bug report.

Thanks!