The Samba-Bugzilla – Bug 10611
No error code returned when removing source file failed
Last modified: 2014-05-25 23:02:03 UTC
Created attachment 9945 [details]
Patch for returning error 26, when removing source files failed.
When rsync is required to remove source files with --remove-source-files option and source files where not removed (eg. due to missing write permission on source dir), no error code is returned, only error message is logged:
rsync: sender failed to remove [file]: Permission denied (13)
One would expect, that user is notified by special error code, that files were tranferred succesfully, but source files were not removed as desired.
I created a small patch to fix this (see attachment).
I'm making rsync exit with the standard partial-transfer error code (which always means that someone needs to check the error messages to see what actually went wrong).