Bug 10576 - root preexec not applying to processes receiving print jobs
Summary: root preexec not applying to processes receiving print jobs
Status: RESOLVED WORKSFORME
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Printing (show other bugs)
Version: 4.1.7
Hardware: All Linux
: P5 normal (vote)
Target Milestone: ---
Assignee: printing-maintainers
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-29 16:59 UTC by Alex K
Modified: 2016-11-10 07:09 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex K 2014-04-29 16:59:30 UTC 
After upgrading my printservers from 3.6.23 to 4.1.7 three weeks ago I noticed a higher CPU usage than usual by smbd. 

I have these lines in my smb.conf:
[print$]
..
  root preexec = /usr/bin/renice +18 -p %d

[printers]
..
  root preexec = /usr/bin/renice +18 -p %d

When testing both versions, I noticed that Samba 3.6 reniced its processes both when user was adding a new printer, and when user submitted a job. Samba 4.1 renices only printer-adding processes. Processes that receive a print job are not reniced. Is this behavior expected with 4.1?
Comment 1 David Disseldorp 2015-01-08 17:22:58 UTC 
Thanks for the report Alex.

Are you using an internal or external spoolss server? "root preexec" commands are only executed by smbd processes forked to handle client connections - the parameter is ignored by external spoolss processes.

That said, is this bug still an issue, given that bug 10652 is now fixed?
Comment 2 Andreas Schneider 2016-11-10 07:09:00 UTC 
Should be fixed with bug #10652