Created attachment 9868 [details] Every 3 minutes check the size of the request queue in the child winbindd process and exit if there are none. With 'winbind max domain connecitons' setting, we can have as many child winbindd processes as the value configured. Also, depending on the number of trusted domains the number of winbindd processes increase. These processes once started during the load do not exit when there is no login activity. This may create unnecessary system load. It would be good to make the child winbindd processes exit if there are no pending requests for it. This attahced patch (git diff) intends to do the same. Please check.
See my comment in https://lists.samba.org/archive/samba-technical/2014-April/099277.html
Created attachment 9875 [details] Cleanup handler is installed in the arent winbindd. Handler checks if the child is free and if so forces it to exit.
Thanks Volker. Yes, the first patch (attachment 9868 [details]) does not work as I expected. I have re worked the patch and attaching a new patch (attachment 9875 [details]). Now cleanup handler is installed in the parent winbindd (winbindd.c). The handler iterates through all domains, all the child processes for each domain, checks if the child queue is empty, then if empty send SIGTERM signal to child. Please check.
Created attachment 9899 [details] Winbindd proces is cleaned only if it remains idle for more than 1 min. Added a smb.conf paramter to control the triggering of the cleanup handler. Attaching an improved patch. Now, cleanup handler waits for an idle winbindd process to remain idle for 1 min. I also thought it would be better to add a smb.conf parameter to control the triggering of this cleanup handler. The new parameter is "winbind idle child cleanup interval". If this parameter is set to '0' (default value) then the cleanup handler is not triggered.
Any more suggestions on latest patch [attachment 9899 [details]]. If not can we take this patch?
If this patch works for you, you're certainly free to use it. Unfortunately I am pretty busy right now, so I had no time yet to go through it thorougly. Might take a few more days, it's in my inbox.
Volker, Actually there is mistake in my previous patch. Apologies for that. Below file change ******** --- a/source3/param/loadparm.c +++ b/source3/param/loadparm.c @@ -861,6 +861,7 @@ static void init_globals(bool reinit_globals) Globals.log_writeable_files_on_exit = false; Globals.create_krb5_conf = true; Globals.winbindMaxDomainConnections = 1; + Globals.machine_password_timeout = 0; ******* should be ************* --- a/source3/param/loadparm.c +++ b/source3/param/loadparm.c @@ -861,6 +861,7 @@ static void init_globals(bool reinit_globals) Globals.log_writeable_files_on_exit = false; Globals.create_krb5_conf = true; Globals.winbindMaxDomainConnections = 1; + Globals.winbind_idle_child_cleanup_interval = 0; ************* will attach corrected patch. Please bear with my little experience with git Samba as well. Meantime we will be testing the patch in our test bed. Thanks,
Created attachment 9919 [details] Corrected wrong parameter initalizing in loadparm.c
have a look at bug #3204