Bug 10542 - re-running provision fails with Samba 4.1 and blames posix ACLs
Summary: re-running provision fails with Samba 4.1 and blames posix ACLs
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.1.6
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-06 22:57 UTC by Andrew Bartlett
Modified: 2016-07-31 02:39 UTC (History)
0 users

See Also:
jelmer: review+

Attachments
4.1 patch cherry-picked from master (4.10 KB, patch)
2014-04-06 22:57 UTC, Andrew Bartlett 		abartlet: review? (jelmer)
 Details
4.1 patch cherry-picked from master (additional #1) (5.65 KB, patch)
2014-04-06 23:45 UTC, Andrew Bartlett 		no flags Details
4.1 patch cherry-picked from master (additional #2) (1.69 KB, patch)
2014-04-06 23:46 UTC, Andrew Bartlett 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2014-04-06 22:57:44 UTC 
Created attachment 9832 [details]
4.1 patch cherry-picked from master

For users running Samba 4.1, a change to the pysmbd python wrapper after 4.0 means that running provision twice fails, whereas it used to just wipe the database and start again.

This causes confusion particularly because it blames the POSIX ACL code.
Comment 1 Jelmer Vernooij 2014-04-06 23:02:18 UTC 
+1, though it would be nice to cherry-pick the version that catches OSError rather than Exception.
Comment 2 Andrew Bartlett 2014-04-06 23:45:53 UTC 
Created attachment 9833 [details]
4.1 patch cherry-picked from master (additional #1)

As requested, the patch that catches the narrower exceptions
Comment 3 Andrew Bartlett 2014-04-06 23:46:13 UTC 
Created attachment 9834 [details]
4.1 patch cherry-picked from master (additional #2)
Comment 4 Andrew Bartlett 2016-07-31 02:39:04 UTC 
Fixed in Samba 4.2 with a89060a0217f8740798d1dac4466222301a4d81b

This never got into 4.1 while this was still being maintained.