When exposing a share shadow-copy of a hidden base share, the MS-FSRVP document states: <8> Section 3.1.4.6: Windows servers expose the shadow copy of the share by invoking the NetrShareAdd() method, as specified in [MS-SRVS] section 3.1.4.7. If MappedShare.ShareName ends with a '$' character (meaning that the share is hidden), then the exposed share name will have the '$' suffix appended. For example, if MappedShare.ShareName is \\server\thisshare$, the exposed name would be \\<any>\thisshare$@{ShadowCopy.ShadowCopyId}$ The existing Samba FSRVP client does not invoke this behaviour when run against a Windows Server 2012 FSRVP server - instead, the exposed share does not include a trailing '$', causing it to be visible. Taking the issue up with Dochelp, it was brought to my attention that, unlike the Windows FSRVP client, rpcclient does not add a trailing backslash to the ShareName in the AddToShadowCopySet request. Once added, snapshots of hidden shares are also hidden.
Created attachment 9822 [details] fix for 4.1.next, cherry-picked from master Includes "rpcclient: abort shadow-copy set on commit failure" and "rpcclient: append a trailing slash to FSRVP request UNCs" from master.
Comment on attachment 9822 [details] fix for 4.1.next, cherry-picked from master LGTM.
Re-assigning to Karolin for inclusion in 4.1.next. Jeremy.
Pushed to autobuild-v4-1-test.
(In reply to comment #4) > Pushed to autobuild-v4-1-test. Pushed to v4-1-test. Closing out bug report. Thanks!