The Samba-Bugzilla – Bug 10467
samba.vfstest.stream_depot test fails against Btrfs
Last modified: 2014-03-25 09:35:18 UTC
The 4.1.x samba.vfstest.stream_depot smbtorture test currently fails against Btrfs
due to vfs_stream_depot's incorrect nlink==2 empty directory checks.
The following upstream (master) fix is required in the 4.1 code-base:
Author: Andreas Schneider <firstname.lastname@example.org>
Date: Fri Nov 8 15:41:18 2013 +0100
s3-vfs: Fix stream_depot vfs module on btrfs.
Checking if the directory is empty using 'nlink == 2' only checks if
there are no subdirectories. It doesn't indicate if there are files in
the directory. However checking link count for no subdirectories is
wrong and applications shouldn't rely on it, see:
Signed-off-by: Andreas Schneider <email@example.com>
Reviewed-by: David Disseldorp <firstname.lastname@example.org>
Created attachment 9715 [details]
fix for v4-1-test branch, cherry-picked from master
Karolin, please merge for 4.1.next.
(In reply to comment #2)
> Karolin, please merge for 4.1.next.
Pushed to autobuild-v4-1-test.
(In reply to comment #3)
> (In reply to comment #2)
> > Karolin, please merge for 4.1.next.
> > Thanks!
> Pushed to autobuild-v4-1-test.
Pushed to v4-1-test.
Closing out bug report.