Bug 10388 - nmbd, smbd, and winbind systemd sysconfig files default setting
Summary: nmbd, smbd, and winbind systemd sysconfig files default setting
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andreas Schneider
QA Contact: Samba QA Contact
Depends on:
Reported: 2014-01-20 12:03 UTC by Lars Müller
Modified: 2014-10-13 10:41 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Lars Müller 2014-01-20 12:03:06 UTC
While starting nmbd, smbd, or winbind via systemd we see in the log files:

Jan 16 18:51:22 hip smbd[31452]: [2014/01/16 18:51:22.487860,  0] ../source3/smbd/server.c:1278(main)
Jan 16 18:51:22 hip smbd[31452]: standard input is not a socket, assuming -D option

The suggested approach to make this DEBUG statement a log level 3 message - see https://lists.samba.org/archive/samba-technical/2014-January/097304.html and https://bugzilla.novell.com/show_bug.cgi?id=857454#c23 - did not got the required acceptance by two developers.  Therefore samba has to stay with a superfluous and useless extra debug message forever.

To lower the log file noise caused by this we need default sysconfig snippets looking like the following one.

## Type:           string
## Default:        "-D"
## ServiceRestart:·winbind

It would be nice if we could split up the winbindd options into a separate file.  I'm happy to file an extra defect report for the content split.
Comment 1 Lars Müller 2014-01-20 14:55:29 UTC
winbindd behaves different than nmbd and smbd.  It assumes the -D option if not present on the command line.  That the documented behavior and visible from the code in source3/winbindd/winbindd.c in the while(opt) part of the main() function.

Therefore I suggest to align the default habit of both daemons.

Either by making the DEBUG statement in nmbd and smbd only a log level 3 or by modifying the winbindd code to be eloquent on the same level as the other two.
Comment 2 Andreas Schneider 2014-04-02 05:45:20 UTC
Fixes pushed to master.
Comment 3 Andreas Schneider 2014-04-02 05:45:43 UTC
Closing. If you want it backported to 4.1 please reopen :)