Bug 10349 - Incorrect comparison in source3/torture/pdbtest.c
Summary: Incorrect comparison in source3/torture/pdbtest.c
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: User & Group Accounts (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-25 18:16 UTC by herwin
Modified: 2013-12-26 17:42 UTC (History)
0 users

See Also:

Attachments
patch (535 bytes, patch)
2013-12-25 18:16 UTC, herwin 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description herwin 2013-12-25 18:16:16 UTC 
Created attachment 9550 [details]
patch

Line 120-121:

  } else if (s1_len != s1_len) {
    DEBUG(0, ("Password history not written correctly, lengths differ, want %d, got %d\n", s1_len, s2_len));

I'm pretty sure that the intention was to compare s1_len with s2_len, not with itself.
Comment 1 Simo Sorce 2013-12-26 04:30:48 UTC 
Sent to samba-technical for review and push