The Samba-Bugzilla – Bug 10348
Empty body in if-statement in continue_domain_open_lookup
Last modified: 2014-10-13 10:52:03 UTC
Line 210 of source4/libnet/libnet_domain.c reads:
This if-statements doesn't do anything. Most likely the line should read
if (!composite_is_ok(c)) return;
because almost every other call to composite_is_ok does this. Otherwise, if nothing should be done, regardless of the result, the line could be replaced by
although I doubt that was the intention.
Yes, I also think that it should be corrected into "if
Created attachment 9921 [details]
Patch from master.
Applies cleanly to v4-1-test and v4-0-test. Please review and include in those branches if possible.
Re-assigning to Karolin for inclusion in 4.1.next, 4.0.next. Patch from master.
Pushed to autobuild-v4-[0|1]-test.
Pushed to both branches.
Closing out bug report.