Bug 10318 - samba-tool says "Expiry disabled" instead of "Set to expired"
samba-tool says "Expiry disabled" instead of "Set to expired"
Status: RESOLVED FIXED
Product: Samba 4.0
Classification: Unclassified
Component: Tools
4.0.13
All All
: P5 normal
: ---
Assigned To: Andrew Bartlett
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-11 09:48 UTC by Björn Jacke
Modified: 2014-09-08 09:45 UTC (History)
1 user (show)

See Also:


Attachments
patch to fix bug 10318 (1.30 KB, patch)
2014-09-08 08:54 UTC, Björn Jacke
metze: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2013-12-11 09:48:37 UTC
# samba-tool user setexpiry someuser --days=0
Expiry for user 'someuser' disabled

This is wrong. "--days=0" sets ths user to disabled immediately. Only the --noexpiry switch disables expiry. The output for the --days=0 case should be fixed.
Comment 1 Björn Jacke 2014-09-08 08:54:38 UTC
Created attachment 10265 [details]
patch to fix bug 10318
Comment 2 Stefan Metzmacher 2014-09-08 09:32:52 UTC
Comment on attachment 10265 [details]
patch to fix bug 10318

Please push to master with my review
Comment 3 Björn Jacke 2014-09-08 09:45:08 UTC
pushed to master - closing