Bug 10310 - Fix AIO with SMB2 and locks
Summary: Fix AIO with SMB2 and locks
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-06 15:07 UTC by Christof Schmitt
Modified: 2013-12-10 15:24 UTC (History)
0 users

See Also:

Attachments
Patches for 4.0 branch (6.16 KB, patch)
2013-12-06 15:50 UTC, Christof Schmitt 		jra: review+
Details
Patches for 4.1 branch (6.21 KB, patch)
2013-12-06 16:25 UTC, Christof Schmitt 		jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christof Schmitt 2013-12-06 15:07:57 UTC 
Holding a lock and then issuing an SMB2 AIO write on the locked region fails.
This can be demonstrated with the smb2.lock.rw-exclusive torture test.
Fixing the problem requires these patches:
https://git.samba.org/?p=samba.git;a=commitdiff;h=dfef0701c398982226dde8a8e15ff97bba0fef53
https://git.samba.org/?p=samba.git;a=commitdiff;h=eadb2a54d1733a482999eb770182156dad1e184d

The same problem exists in 4.0 and 4.1.
Comment 1 Christof Schmitt 2013-12-06 15:50:53 UTC 
Created attachment 9511 [details]
Patches for 4.0 branch
Comment 2 Christof Schmitt 2013-12-06 16:25:57 UTC 
Created attachment 9512 [details]
Patches for 4.1 branch
Comment 3 Jeremy Allison 2013-12-06 19:17:22 UTC 
Comment on attachment 9511 [details]
Patches for 4.0 branch

LGTM.
Comment 4 Jeremy Allison 2013-12-06 19:17:32 UTC 
Comment on attachment 9512 [details]
Patches for 4.1 branch

LGTM.
Comment 5 Jeremy Allison 2013-12-06 19:17:55 UTC 
Re-assigning to Karolin for inclusion in 4.0.next, 4.1.next.

Jeremy.
Comment 6 Karolin Seeger 2013-12-10 12:02:04 UTC 
Pushed to autobuild-v4-0-test.
Comment 7 Karolin Seeger 2013-12-10 12:03:25 UTC 
user@host:/data/git/samba/v4-1-test$ git am v4-1-test.patch 
Applying: smbd: Fix bug 10284
error: patch failed: source3/lib/msg_channel.c:41
error: source3/lib/msg_channel.c: patch does not apply
Patch failed at 0001 smbd: Fix bug 10284
(In reply to comment #6)
> Pushed to autobuild-v4-0-test.

... and autobuild-v4-1-test.
Comment 8 Karolin Seeger 2013-12-10 15:24:00 UTC 
Pushed to v4-0-test and v4-1-test.
Closing out bug report.

Thanks!