Created attachment 9495 [details] patch file If for example you set require_membership_of specified=bogus where bogus ( like it hints is a non existent group ) then you will be happily authenticated. This imho wrong and dangerous as you easily might not notice a typo when entering that field, it would be better to fail in this case ( and force the administrator to investigate ) see mailing list thread https://lists.samba.org/archive/samba-technical/2013-November/096411.html (with associated patch ack) and additionally the patch attached to this bug
Comment on attachment 9495 [details] patch file This patch is on it's way onto the master branch following review from Andreas and I. @Noel, can you please confirm the patch cleanly applies and is suitable for 4.0 and 4.1. Feel free to attach new patches for the maintenance branches if needed.
(In reply to comment #1) > @Noel, can you please confirm the patch cleanly applies and is suitable for 4.0 > and 4.1 git am succeeds for latest pulled v3.6-stable, v4.0-stable & v4.1-stable
(In reply to comment #2) > (In reply to comment #1) > > > @Noel, can you please confirm the patch cleanly applies and is suitable for 4.0 > > and 4.1 > git am succeeds for latest pulled v3.6-stable, v4.0-stable & v4.1-stable Great, I'll attach the patch which has the reviewed-buy and bug# attributes attached.
Created attachment 9496 [details] Patch from master, applies to 3.6, 4.0 and 4.1
(In reply to comment #4) > Created attachment 9496 [details] > Patch from master, applies to 3.6, 4.0 and 4.1 Gah, I (Noel is innocent) pasted the wrong Bugzilla URL in the master commit. I'll fix it for the backport and resubmit.
Created attachment 9499 [details] Patch from master with fixed bug ID, applies to 3.6, 4.0 and 4.1
Comment on attachment 9499 [details] Patch from master with fixed bug ID, applies to 3.6, 4.0 and 4.1 +1
Karolin, please merge.
(In reply to comment #8) > Karolin, please merge. Sorry, I need a second review first. Volunteers?
Comment on attachment 9499 [details] Patch from master with fixed bug ID, applies to 3.6, 4.0 and 4.1 The master commit was reviewed by Andreas and myself. This is the same patch, with the bugzilla ID fixed.
(In reply to comment #10) > Comment on attachment 9499 [details] > Patch from master with fixed bug ID, applies to 3.6, 4.0 and 4.1 > > The master commit was reviewed by Andreas and myself. This is the same patch, > with the bugzilla ID fixed. Ok, thanks, but I need explicit review flags (or comments) in the bug report, not only in the commit message. To be picky, I need it for each version separately...
(In reply to comment #11) > (In reply to comment #10) > > Comment on attachment 9499 [details] [details] > > Patch from master with fixed bug ID, applies to 3.6, 4.0 and 4.1 > > > > The master commit was reviewed by Andreas and myself. This is the same patch, > > with the bugzilla ID fixed. > > Ok, thanks, but I need explicit review flags (or comments) in the bug report, > not only in the commit message. Fair enough :) I've requested review from Jeremy and Andreas. > To be picky, I need it for each version separately... Does that mean you want separate versions of the (same) patch attached for 3.6, 4.0 and 4.1?
(In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #10) > > > Comment on attachment 9499 [details] [details] [details] > > > Patch from master with fixed bug ID, applies to 3.6, 4.0 and 4.1 > > > > > > The master commit was reviewed by Andreas and myself. This is the same patch, > > > with the bugzilla ID fixed. > > > > Ok, thanks, but I need explicit review flags (or comments) in the bug report, > > not only in the commit message. > > Fair enough :) > I've requested review from Jeremy and Andreas. Thanks! > > To be picky, I need it for each version separately... > > Does that mean you want separate versions of the (same) patch attached for 3.6, > 4.0 and 4.1? Some team members would prefer that, yes, but we have never agreed on the team list, so that's not 100% clear.
Comment on attachment 9499 [details] Patch from master with fixed bug ID, applies to 3.6, 4.0 and 4.1 LGTM.
Created attachment 9505 [details] Patch from master with fixed bug ID and adjusted path, applies to 3.3
Created attachment 9506 [details] Patch from master with fixed bug ID, applies to 3.4
Created attachment 9507 [details] Patch from master with fixed bug ID, applies to 3.5
Comment on attachment 9499 [details] Patch from master with fixed bug ID, applies to 3.6, 4.0 and 4.1 Garming and reproduced and tested this yesterday, and confirm it fixes the issue.
Patch already in master. Pushed to v4-1-test, v4-0-test and v3-6-stable. Closing out bug report. Thanks!