Bug 1025 - Configure test for broken NIS+ includes is itself broken
Summary: Configure test for broken NIS+ includes is itself broken
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.2
Hardware: All FreeBSD
: P3 normal
Target Milestone: none
Assignee: Tim Potter
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-01 07:30 UTC by Gert-Jan Vons
Modified: 2005-11-14 09:27 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gert-Jan Vons 2004-02-01 07:30:38 UTC 
Samba's configure.in has a check for broken NIS+ includes.

However, the test itself is broken, because this test forgets to include
sys/types.h before sys/acl.h. It therefor erroneously thinks FreeBSD(5.2)'s NIS+
includes are broken as well, which is not the case.

After adding a #include <sys/types.h>, everything is fine again...
(like everywhere else in configure.in where sys/acl.h is used)

PS: I couldn't select Version 3.0.2 in bugzilla, it stops at 3.0.1

--- ../orig/samba-3.0.2rc1/source/configure.in  Fri Jan 16 18:47:52 2004
+++ configure.in Sun Feb  1 15:07:04 2004
@@ -2208,7 +2208,8 @@
 esac

 AC_CACHE_CHECK([for broken nisplus include
files],samba_cv_BROKEN_NISPLUS_INCLUDE_FILES,[
-AC_TRY_COMPILE([#include <sys/acl.h>
+AC_TRY_COMPILE([#include <sys/types.h>
+#include <sys/acl.h>
 #if defined(HAVE_RPCSVC_NIS_H)
 #include <rpcsvc/nis.h>
 #endif],
Comment 1 Tim Potter 2004-02-01 14:19:18 UTC 
Checked in - thanks!

I've also added 3.0.2rc1 to the list of versions for Samba 3.0
Comment 2 Gerald (Jerry) Carter (dead mail address) 2004-02-01 15:19:07 UTC 
i generally don't add versions for non stable releases 
as this list would get too long IMO.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2004-02-01 15:21:23 UTC 
or at least I quit once 3.0.0 was released.  Renamed 3.0.2rc1 to 3.0.2
Comment 4 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:17:29 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.
Comment 5 Gerald (Jerry) Carter (dead mail address) 2005-11-14 09:27:35 UTC 
database cleanup