Bug 10211 - Log lines sent to files should not human-readable-ize numbers, ever
Log lines sent to files should not human-readable-ize numbers, ever
Status: RESOLVED FIXED
Product: rsync
Classification: Unclassified
Component: core
3.1.0
All All
: P5 normal
: ---
Assigned To: Wayne Davison
Rsync QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-16 09:01 UTC by Tobias Klausmann
Modified: 2013-10-27 17:02 UTC (History)
0 users

See Also:


Attachments
Make end-of-sync log line not use commas if logfile_name!=NULL (1009 bytes, patch)
2013-10-16 09:01 UTC, Tobias Klausmann
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Klausmann 2013-10-16 09:01:43 UTC
Created attachment 9292 [details]
Make end-of-sync log line not use commas if logfile_name!=NULL

There is no reason to do comma separation for numbers if the log lines are sent to a file. Actually, parsing those log files becomes quite a bit messier if they are.

Relatedly, the separator for the numbers seems to ignore locale, in Germany, for example, a million plus 1/10 is written like this: 1.000.000,1 -- not that I'd want either in my logfiles.

Attached is a patch. Not sure about the line width, but that is easily fixable.
Comment 1 Wayne Davison 2013-10-27 17:02:01 UTC
Indeed, the log was supposed to remain unaffected, but that FLOG message had the wrong number-producing code.  I'm checked-in a fix.