The Samba-Bugzilla – Bug 10211
Log lines sent to files should not human-readable-ize numbers, ever
Last modified: 2013-10-27 17:02:01 UTC
Created attachment 9292 [details]
Make end-of-sync log line not use commas if logfile_name!=NULL
There is no reason to do comma separation for numbers if the log lines are sent to a file. Actually, parsing those log files becomes quite a bit messier if they are.
Relatedly, the separator for the numbers seems to ignore locale, in Germany, for example, a million plus 1/10 is written like this: 1.000.000,1 -- not that I'd want either in my logfiles.
Attached is a patch. Not sure about the line width, but that is easily fixable.
Indeed, the log was supposed to remain unaffected, but that FLOG message had the wrong number-producing code. I'm checked-in a fix.