The Samba-Bugzilla – Bug 10195
wbinfo --lookup-sids fails with more than 129 SIDs
Last modified: 2013-10-29 09:13:35 UTC
in a script I'm doing the following lookup:
> wbinfo --lookup-sids $sid_list
If $sid_list contains less than 130 SIDs everything is fine, if there are 130 or more the result is an error:
wbcLookupSids failed: WBC_ERR_WINBIND_NOT_AVAILABLE
Could not lookup SIDs <all the comma separated SIDs>
There is no specific debug output in any logfiles (log.wb-, debug).
Just tried: This seems to work for me. Is it possible that you are running into a limit for the command line length? 129 SIDs could typically take roughly 8k of string space. Could this be a limit on your platform?
I don't think it's a problem with the shell. The ARG_MAX on my FreeBSD system is 256 k.
* If the command line were truncated I expect some SIDs missing in the result, but not an error complaining about the winbind daemon
* The error message contains the correct number of SIDs, so the complete list must be in wbinfo.
Can you get us the equivalent of what would be an strace (ktrace/kdump) of the wbinfo command, together with debug level 10 logs of winbind?
I just created a trace but I'm not sure what kind confidential data is in there...
When providing ~220 SIDs there is a call in the trace with exactly 4096 bytes (87 SIDs and a crippled one.
When providing only 5 SIDs this buffer is 236 bytes including a final "\0". This final "\0" is missing in the case before!
Somewhere in wbinfo is a buffer hard coded to 4k length. When there is 4k or more of input data there is no space left for the string termination and something goes wrong.
The final error message prints out all given SIDs in 1k-chunks.
Created attachment 9289 [details]
Can you try the attached patch?
Created attachment 9309 [details]
Created attachment 9310 [details]
Created attachment 9311 [details]
Comment on attachment 9311 [details]
Thanks for doing the port
Karolin, could you please add the patches to the next 4.1, 4.0 and 3.6 release?
Pushed to autobuild-v4-1-test, autobuild-v4-0-test and v3-6-test.
Pushed to v4-1-test and v4-0-test.
Closing out bug report.