Bug 10168 - Konica Minolta relays on native os
Summary: Konica Minolta relays on native os
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.1.12
Hardware: All All
: P5 normal (vote)
Target Milestone: 4.2
Assignee: Björn Jacke
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 10077
  Show dependency tree / graph
 
Reported: 2013-09-26 10:26 UTC by Daniel Hoffmann
Modified: 2014-10-19 13:14 UTC (History)
1 user (show)

See Also:
bjacke: review? (jra)

Attachments
native-os-patch (584 bytes, text/plain)
2013-11-13 17:39 UTC, Björn Jacke 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Hoffmann 2013-09-26 10:26:27 UTC 
Konica Minolta's Bizub 350 "Scan to SMB" function doesn't work if the server/samba sets "Unix" as native os in the SMB response.

The WFM fix is
Index: samba-3.5.6~dfsg/source3/smbd/sesssetup.c
===================================================================
--- samba-3.5.6~dfsg.orig/source3/smbd/sesssetup.c      2013-09-26 11:33:39.872963387 +0200
+++ samba-3.5.6~dfsg/source3/smbd/sesssetup.c   2013-09-26 11:35:24.615963457 +0200
@@ -74,7 +74,9 @@

        result = 0;

-       tmp = message_push_string(outbuf, "Unix", STR_TERMINATE);
+       /* lie for Konica Minolta
+       tmp = message_push_string(outbuf, "Unix", STR_TERMINATE); */
+       tmp = message_push_string(outbuf, "Windows 5.0", STR_TERMINATE);

        if (tmp == -1) return -1;
        result += tmp;

The error cocde from the device is "ED09CC", according to the manual:
"Check the status of the destination device. A Scan to SMB transmission cannot be performed with a UNIX or LINUX system".

Anyways, telling the device a lie via native os, everything works fine.

Thank you and kind regards,
Daniel
Comment 1 Volker Lendecke 2013-09-26 15:33:30 UTC 
How did you find out *that*? :-)

I'd rather make that a parametric parameter. This is the first time in 20 years of Samba that we need this. And I'm sure there will be other devices later that stuble 5.0 version number...
Comment 2 Björn Jacke 2013-11-13 17:39:47 UTC 
can you have a look if this patch also satifies that printer? It currently says
we are native os "Windows 6.1"
Comment 3 Björn Jacke 2013-11-13 17:39:49 UTC 
Created attachment 9415 [details]
native-os-patch
Comment 4 Björn Jacke 2014-01-17 11:18:34 UTC 
this is in mastrer now. We should

git cherry-pick -x 666948c776948a8147501d2ba590bcd05e78458d

for 4.0 and 4.1.
Comment 5 Björn Jacke 2014-10-19 13:14:00 UTC 
fixed for 4.2.