Bug 10162 - POSIX ACL mapping failing when setting DENY ACE's from Windows.
POSIX ACL mapping failing when setting DENY ACE's from Windows.
Status: RESOLVED FIXED
Product: Samba 4.0
Classification: Unclassified
Component: File services
unspecified
All All
: P5 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks: 9306
  Show dependency treegraph
 
Reported: 2013-09-21 01:08 UTC by Jeremy Allison
Modified: 2013-09-23 10:06 UTC (History)
0 users

See Also:


Attachments
git-am fix proposed to master (1.06 KB, patch)
2013-09-21 01:19 UTC, Jeremy Allison
no flags Details
git-am fix that went into master (1.22 KB, patch)
2013-09-21 04:06 UTC, Jeremy Allison
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2013-09-21 01:08:14 UTC
Bug introduced in the re-write from 3.6.x to 4.0.x (and beyond).

add_current_ace_to_acl() is checking a pointer, instead of its contents. The variable name used to be a bool value, and the code wasn't changed in one place when it was moved to being a pointer to bool value instead of a bool value.

Fix to follow.

Jeremy.
Comment 1 Jeremy Allison 2013-09-21 01:19:14 UTC
Created attachment 9234 [details]
git-am fix proposed to master

Will update with the patch from master and cherry-pick info once it's been integrated.

Jeremy.
Comment 2 Jeremy Allison 2013-09-21 04:06:26 UTC
Created attachment 9235 [details]
git-am fix that went into master

This is the fix that went into master.

Can be picked for 4.1.0 and 4.0.x by:

git cherry-pick -x e24fcf0f3e1b5b19d97a13786b09f069393b06d8

Required for both 4.0.x and 4.1.0.

Jeremy.
Comment 3 Jeremy Allison 2013-09-21 04:07:32 UTC
Re-assigning to Karolin for inclusion as this is the fix that went into master that applies cleanly to 4.1.0 and 4.0.next.

Already reviewed by Jeremy Allison and Michael Adam.

Jeremy.
Comment 4 Karolin Seeger 2013-09-23 07:28:44 UTC
Pushed to autobuild-v4-1-test and autobuild-v4-0-test.
Comment 5 Karolin Seeger 2013-09-23 10:06:48 UTC
Pushed to v4-1-test and v4-0-test.
Closing out bug report.

Thanks!