Attachment 9921 Details for Bug 10348 – Patch from master.

[patch] Patch from master.

0001-Fix-an-empty-if-statement.patch (text/plain), 1.05 KB, created by José A. Rivera on 2014-05-07 13:42:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: José A. Rivera

Created: 2014-05-07 13:42:21 UTC

Size: 1.05 KB

patch

obsolete

>From 2c9683db4ba07436490edd38c535ff53e92f1960 Mon Sep 17 00:00:00 2001
>From: "Jose A. Rivera" <jarrpa@redhat.com>
>Date: Mon, 5 May 2014 06:46:58 -0500
>Subject: [PATCH 1/2] Fix an empty if statement.
>
>Primarily following the	precedent set by other uses of composite_is_ok(), but
>also making sure nothing tries to use c after this point if it is in fact not
>ok.
>
>Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>---
> source4/libnet/libnet_domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source4/libnet/libnet_domain.c b/source4/libnet/libnet_domain.c
>index 70ed31d..27a3e55 100644
>--- a/source4/libnet/libnet_domain.c
>+++ b/source4/libnet/libnet_domain.c
>@@ -207,7 +207,7 @@ static void continue_domain_open_lookup(struct tevent_req *subreq)
> 	r = &s->open;
> 
> 	/* check the rpc layer status */
>-	if (!composite_is_ok(c));
>+	if (!composite_is_ok(c)) return;
> 
> 	/* check the rpc call itself status */
> 	if (!NT_STATUS_IS_OK(s->lookup.out.result)) {
>-- 
>1.8.3.1
>

Flags:

jra: review+
vl: review+

Actions: View

Attachments on bug 10348: 9921