The Samba-Bugzilla – Attachment 9676 Details for
Bug 10436
cancel fsp->oplock_timeout in downgrade_file_oplock()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch for v4-0-test
tmp40.diff (text/plain), 1.07 KB, created by
Stefan Metzmacher
on 2014-02-11 11:10:10 UTC
(
hide
)
Description:
Patch for v4-0-test
Filename:
MIME Type:
Creator:
Stefan Metzmacher
Created:
2014-02-11 11:10:10 UTC
Size:
1.07 KB
patch
obsolete
>From 6f5b5dd281ad1e12ead8a611ce5494d0032a303e Mon Sep 17 00:00:00 2001 >From: Volker Lendecke <vl@samba.org> >Date: Wed, 4 Sep 2013 13:57:00 +0200 >Subject: [PATCH] smbd: Fix an ancient oplock bug > >If we get an oplock break response, we forgot to remove the oplock break >timeout. > >Found by stopping raw.oplock.exclusive5 after the 2nd open and watching a debug >level 10 log. This amends 08a9de89 from 2007. > >Signed-off-by: Volker Lendecke <vl@samba.org> >Reviewed-by: Jeremy Allison <jra@samba.org> >(cherry picked from commit 0670975261c5f29394f9e9d25f899a7de948dad1) >--- > source3/smbd/oplock.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c >index 406ffd1..95d88ef 100644 >--- a/source3/smbd/oplock.c >+++ b/source3/smbd/oplock.c >@@ -150,6 +150,8 @@ static void downgrade_file_oplock(files_struct *fsp) > sconn->oplocks.exclusive_open--; > sconn->oplocks.level_II_open++; > fsp->sent_oplock_break = NO_BREAK_SENT; >+ >+ TALLOC_FREE(fsp->oplock_timeout); > } > > /**************************************************************************** >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
vl
:
review+
jra
:
review+
Actions:
View
Attachments on
bug 10436
:
9675
| 9676