Attachment 9234 Details for Bug 10162 – git-am fix proposed to master

[patch] git-am fix proposed to master

0001-Fix-bug-10162-POSIX-ACL-mapping-failing-when-setting.patch (text/plain), 1.06 KB, created by Jeremy Allison on 2013-09-21 01:19:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2013-09-21 01:19:14 UTC

Size: 1.06 KB

patch

obsolete

>From 7e6f35080ce5faab4b3557d911bf18ead905d4cc Mon Sep 17 00:00:00 2001
>From: Daniel Liberman <danielvl@gmail.com>
>Date: Thu, 19 Sep 2013 20:28:33 -0300
>Subject: [PATCH] Fix bug 10162 - POSIX ACL mapping failing when setting DENY
> ACE's from Windows.
>
>Fix for ACL problem - not accepting DENY. Code was checking for pointer and not for content.
>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>---
> source3/smbd/posix_acls.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c
>index 3b9be9d..ad1431d 100644
>--- a/source3/smbd/posix_acls.c
>+++ b/source3/smbd/posix_acls.c
>@@ -1808,7 +1808,7 @@ static bool add_current_ace_to_acl(files_struct *fsp, struct security_ace *psa,
> 		if (current_ace->attr == ALLOW_ACE)
> 			*got_file_allow = True;
> 
>-		if ((current_ace->attr == DENY_ACE) && got_file_allow) {
>+		if ((current_ace->attr == DENY_ACE) && *got_file_allow) {
> 			DEBUG(0,("add_current_ace_to_acl: malformed "
> 				 "ACL in file ACL ! Deny entry after "
> 				 "Allow entry. Failing to set on file "
>-- 
>1.7.9.5
>

Actions: View

Attachments on bug 10162: 9234 | 9235