Attachment 8900 Details for Bug 9891 – Patch to fix issue via git format-patch

[patch] Patch to fix issue via git format-patch

nm-openbsd.patch (text/plain), 991 bytes, created by Vadim Zhukov on 2013-05-17 08:47:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vadim Zhukov

Created: 2013-05-17 08:47:52 UTC

Size: 991 bytes

patch

obsolete

>From 3ed42c3777667bdebe94512b8a4621ba9f1fd265 Mon Sep 17 00:00:00 2001
>From: Vadim Zhukov <persgray@gmail.com>
>Date: Fri, 17 May 2013 12:48:26 +0400
>Subject: [PATCH] Do not add -D to nm(1) command line on OpenBSD
>
>OpenBSD nm(1) defaults to show dynamic symbol table, and does not
>have -D option either.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=9891
>---
> buildtools/wafsamba/symbols.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/buildtools/wafsamba/symbols.py b/buildtools/wafsamba/symbols.py
>index daa18b9..cf15e25 100644
>--- a/buildtools/wafsamba/symbols.py
>+++ b/buildtools/wafsamba/symbols.py
>@@ -46,8 +46,8 @@ def symbols_extract(bld, objfiles, dynamic=False):
>         return ret
> 
>     cmd = ["nm"]
>-    if dynamic:
>-        # needed for some .so files
>+    if dynamic and not sys.platform.startswith("openbsd"):
>+        # needed for some .so files on non-OpenBSD platforms
>         cmd.append("-D")
>     cmd.extend(list(objfiles))
> 
>-- 
>1.8.2.2
>

Flags:

bjacke: review-

Actions: View

Attachments on bug 9891: 8893 | 8900