Attachment 8658 Details for Bug 9728 – patches cherry-picked from master

[patch] patches cherry-picked from master

0001-scripting-No-longer-install-samba_upgradeprovision.patch (text/plain), 2.07 KB, created by Andrew Bartlett on 2013-03-18 22:11:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Bartlett

Created: 2013-03-18 22:11:55 UTC

Size: 2.07 KB

patch

obsolete

>From 2d206686c95f42092324e09418d06663165685c8 Mon Sep 17 00:00:00 2001
>From: Andrew Bartlett <abartlet@samba.org>
>Date: Thu, 28 Feb 2013 00:03:19 +1100
>Subject: [PATCH] scripting: No longer install samba_upgradeprovision
>
>This tool is an important part of the toolkit a Samba Team member can
>use to assist a user with the upgrade of a very old Samba 4.0 AD DC
>installation.
>
>However, like all powerful tools, it has sharp edges, and these need
>to have more protection added before we recommend the tool be used.
>
>The WHATSNEW already indicated that this tool should not be used but a
>large number of users have run it, and due to lack of testing in the
>past, some have run into bugs.
>
>While this tool can be run in debug modes, by default it simply fixes
>the database following a series of internal rule.  This does a good
>job much of the time, but does not request permission in the way that
>dbcheck does, and will create extra objects for things like the DNS
>partitions.
>
>By removing this from the installed binaries, we provide another
>signal that it should not be used right now, until these matters are
>fixed and some clear documentation on how to safely use the tool can
>be written.
>
>Andrew Bartlett
>
>Reviewed-by: Michael Adam <obnox@samba.org>
>
>Autobuild-User(master): Michael Adam <obnox@samba.org>
>Autobuild-Date(master): Tue Mar 12 02:51:23 CET 2013 on sn-devel-104
>(cherry picked from commit 389197e7c31e8d6616e6503181c088940ddb5986)
>---
> source4/scripting/wscript_build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source4/scripting/wscript_build b/source4/scripting/wscript_build
>index 9af23f6..39408ba 100644
>--- a/source4/scripting/wscript_build
>+++ b/source4/scripting/wscript_build
>@@ -4,7 +4,7 @@ from samba_utils import MODE_755
> 
> sbin_files = None
> if bld.CONFIG_SET('AD_DC_BUILD_IS_ENABLED'):
>-    sbin_files = 'bin/samba_upgradeprovision bin/samba_dnsupdate bin/samba_spnupdate bin/samba_upgradedns bin/samba_kcc'
>+    sbin_files = 'bin/samba_dnsupdate bin/samba_spnupdate bin/samba_upgradedns bin/samba_kcc'
> 
> if sbin_files:
>     bld.INSTALL_FILES('${SBINDIR}',
>-- 
>1.7.11.7
>

Flags:

metze: review+
obnox: review+

Actions: View

Attachments on bug 9728: 8658