Attachment 8273 Details for Bug 9456 – patch for v4-0-test

[patch] patch for v4-0-test

0001-s3-smbd-vfs_acl-fix-a-PANIC-when-setting-an-ACL-fail.v4-0.test.patch (text/plain), 1.31 KB, created by Michael Adam on 2012-12-04 10:40:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Adam

Created: 2012-12-04 10:40:28 UTC

Size: 1.31 KB

patch

obsolete

>From 5dbd5cd7756afa3e89a17eaf6f72f9b3b97ed04c Mon Sep 17 00:00:00 2001
>From: Michael Adam <obnox@samba.org>
>Date: Tue, 4 Dec 2012 02:02:07 +0100
>Subject: [PATCH] s3:smbd:vfs_acl: fix a PANIC when setting an ACL fails with
> ACCESS_DENIED
>
>Omission to free the talloc frame causes a panic (at least in developer mode)
>in the next main event loop due to "Frame not freed in order."
>(Freed frame ../source3/smbd/process.c:3617, expected ../source3/modules/vfs_acl_common.c:534.)
>
>Signed-off-by: Michael Adam <obnox@samba.org>
>Reviewed-by: Stefan Metzmacher <metze@samba.org>
>
>Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
>Autobuild-Date(master): Tue Dec  4 09:03:25 CET 2012 on sn-devel-104
>(cherry picked from commit 4a8028a96e20f140c2d423efd4c010a7d300ca72)
>---
> source3/modules/vfs_acl_common.c |    1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
>index 59ced29..4e3aa72 100644
>--- a/source3/modules/vfs_acl_common.c
>+++ b/source3/modules/vfs_acl_common.c
>@@ -590,6 +590,7 @@ static NTSTATUS fset_nt_acl_common(vfs_handle_struct *handle, files_struct *fsp,
> 		if (get_current_uid(handle->conn) == 0 ||
> 				chown_needed == false ||
> 				!(fsp->access_mask & SEC_STD_WRITE_OWNER)) {
>+			TALLOC_FREE(frame);
> 			return NT_STATUS_ACCESS_DENIED;
> 		}
> 
>-- 
>1.7.9.5
>

Flags:

obnox: review+
metze: review+

Actions: View

Attachments on bug 9456: 8273