Attachment 8206 Details for Bug 9392 – Patches cherry-picked from master for samba-tool fsmo fix

[patch] Patches cherry-picked from master for samba-tool fsmo fix

0001-s4-samba-tool-Fix-samba-tool-fsmo-role-schema.patch (text/plain), 1.74 KB, created by Andrew Bartlett on 2012-11-16 04:59:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Bartlett

Created: 2012-11-16 04:59:06 UTC

Size: 1.74 KB

patch

obsolete

>From 87483ecad4abbd116bfd524e7f6f53d216fe40cf Mon Sep 17 00:00:00 2001
>From: Arvid Requate <requate@univention.de>
>Date: Wed, 14 Nov 2012 15:51:19 +0100
>Subject: [PATCH] s4:samba-tool: Fix samba-tool fsmo --role=schema
>
>Fix traceback:
>samba-tool fsmo --role=schema --force
>ERROR(<type 'exceptions.TypeError'>): uncaught exception - argument 2 must be string, not ldb.Dn
>  File "/usr/lib/python2.6/dist-packages/samba/netcmd/__init__.py", line 168, in _run
>    return self.run(*args, **kwargs)
>  File "/usr/lib/python2.6/dist-packages/samba/netcmd/fsmo.py", line 160, in run
>    self.seize_role(role, samdb, force)
>  File "/usr/lib/python2.6/dist-packages/samba/netcmd/fsmo.py", line 119, in seize_role
>    m.dn = ldb.Dn(samdb, self.schema_dn)
>
>Reviewed-by: Andrew Bartlett <abartlet@samba.org>
>
>Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
>Autobuild-Date(master): Fri Nov 16 00:40:24 CET 2012 on sn-devel-104
>(cherry picked from commit ace0909b88739338e948b9c1e98307f324bb7503)
>---
> source4/scripting/python/samba/netcmd/fsmo.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source4/scripting/python/samba/netcmd/fsmo.py b/source4/scripting/python/samba/netcmd/fsmo.py
>index 15d1d49..c938c91 100644
>--- a/source4/scripting/python/samba/netcmd/fsmo.py
>+++ b/source4/scripting/python/samba/netcmd/fsmo.py
>@@ -103,7 +103,7 @@ all=all of the above"""),
>         domain_dn = samdb.domain_dn()
>         self.infrastructure_dn = "CN=Infrastructure," + domain_dn
>         self.naming_dn = "CN=Partitions,%s" % samdb.get_config_basedn()
>-        self.schema_dn = samdb.get_schema_basedn()
>+        self.schema_dn = str(samdb.get_schema_basedn())
>         self.rid_dn = "CN=RID Manager$,CN=System," + domain_dn
> 
>         m = ldb.Message()
>-- 
>1.7.11.7
>

Flags:

abartlet: review? (jelmer)
obnox: review+

Actions: View

Attachments on bug 9392: 8191 | 8204 | 8206