Traceback in samba-tool fsmo --role=schema :
ERROR(<type 'exceptions.TypeError'>): uncaught exception - argument 2 must be string, not ldb.Dn
File "/usr/lib/python2.6/dist-packages/samba/netcmd/__init__.py", line 168, in _run
return self.run(*args, **kwargs)
File "/usr/lib/python2.6/dist-packages/samba/netcmd/fsmo.py", line 160, in run
self.seize_role(role, samdb, force)
File "/usr/lib/python2.6/dist-packages/samba/netcmd/fsmo.py", line 119, in seize_role
m.dn = ldb.Dn(samdb, self.schema_dn)
Possibly introduced by commit 6b2753d71ea9e9a64fa749cfeeaef4f451c6cae4
Created attachment 8191 [details]
Patch against master
Created attachment 8204 [details]
Patch against master (actually fixing the code block in question...)
Thanks. I'll guide this into master and then cherry-pick for 4.0.
Created attachment 8206 [details]
Patches cherry-picked from master for samba-tool fsmo fix
This is in master, replacing with patch with cherry-pick and review markers
Karolin, are Andrew's comments here enough as a second review+ ?
Pushed to autobuild-v4-0-test.
Pushed to v4-0-test.
Closing out bug report.