The Samba-Bugzilla – Attachment 7873 Details for
Bug 9150
Valid open requests can cause smbd assert due to incorrect oplock handling on delete requests.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
git-am fix for 3.5.next.
0001-s3-delete-requests-are-not-special.patch (text/plain), 1.40 KB, created by
Jeremy Allison
on 2012-09-10 21:20:25 UTC
(
hide
)
Description:
git-am fix for 3.5.next.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2012-09-10 21:20:25 UTC
Size:
1.40 KB
patch
obsolete
>From bc779c1ae0260761fa304affc8944df6e2edd8c0 Mon Sep 17 00:00:00 2001 >From: Volker Lendecke <vl@samba.org> >Date: Mon, 10 Sep 2012 11:25:03 +0200 >Subject: [PATCH] s3: delete requests are not special > >The only difference between batch and exclusive oplocks is the time of >the check: Batch is checked before the share mode check, exclusive after. > >Signed-off-by: Jeremy Allison <jra@samba.org> >--- > source3/smbd/open.c | 13 ++----------- > 1 files changed, 2 insertions(+), 11 deletions(-) > >diff --git a/source3/smbd/open.c b/source3/smbd/open.c >index dfa45ef..843bb2b 100644 >--- a/source3/smbd/open.c >+++ b/source3/smbd/open.c >@@ -894,11 +894,6 @@ static NTSTATUS open_mode_check(connection_struct *conn, > return NT_STATUS_OK; > } > >-static bool is_delete_request(files_struct *fsp) { >- return ((fsp->access_mask == DELETE_ACCESS) && >- (fsp->oplock_type == NO_OPLOCK)); >-} >- > /* > * Send a break message to the oplock holder and delay the open for > * our client. >@@ -1002,13 +997,9 @@ static bool delay_for_oplocks(struct share_mode_lock *lck, > } > > if (exclusive != NULL) { /* Found an exclusive oplock */ >- bool delay_it = is_delete_request(fsp) ? >- BATCH_OPLOCK_TYPE(exclusive->op_type) : true; > SMB_ASSERT(!have_level2); >- if (delay_it) { >- send_break_message(fsp, exclusive, mid, oplock_request); >- return true; >- } >+ send_break_message(fsp, exclusive, mid, oplock_request); >+ return true; > } > > /* >-- >1.7.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
vl
:
review+
Actions:
View
Attachments on
bug 9150
:
7872
| 7873