The Samba-Bugzilla – Attachment 7449 Details for
Bug 8859
Wrong assertion: Checks pointer not value
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
0001-Wrong-assertion-comparison-Compare-value-not-pointer.patch (text/plain), 957 bytes, created by
Olaf Flebbe
on 2012-04-12 11:18:14 UTC
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Olaf Flebbe
Created:
2012-04-12 11:18:14 UTC
Size:
957 bytes
patch
obsolete
>From 12302e2b4c58549df6959f64e9d3b1693803e721 Mon Sep 17 00:00:00 2001 >From: Olaf Flebbe <o.flebbe@science-computing.de> >Date: Thu, 12 Apr 2012 11:29:41 +0200 >Subject: [PATCH] Wrong assertion/comparison: Compare value not pointer > >--- > source3/registry/reg_parse.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/source3/registry/reg_parse.c b/source3/registry/reg_parse.c >index a112572..5a22fd7 100644 >--- a/source3/registry/reg_parse.c >+++ b/source3/registry/reg_parse.c >@@ -791,12 +791,12 @@ handle_iconv_errno(int err, const char* obuf, size_t linenum, > DEBUG(0, ("Illegal multibyte sequence at line %lu: %s", > (long unsigned)(linenum+1), pos)); > >- assert(ilen > 0); >+ assert((*ilen) > 0); > do { > size_t il = 1; > DEBUGADD(0, ("<%02x>", (unsigned char)**iptr)); > >- if (olen > 0) { >+ if ((*olen) > 0) { > *(*optr)++ = '\?'; > (*iptr)++; > /* Todo: parametrize, e.g. skip: *optr++ = *iptr++; */ >-- >1.7.3.4 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=7449">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Flags:
jra
:
review+
Actions:
View
Attachments on
bug 8859
: 7449