The Samba-Bugzilla – Attachment 5645 Details for
Bug 7378
"net conf import" fails silently on parameter typo
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch for 3.5
3.5.diff (text/plain), 852 bytes, created by
Jim McDonough
on 2010-04-20 15:48:47 UTC
(
hide
)
Description:
Patch for 3.5
Filename:
MIME Type:
Creator:
Jim McDonough
Created:
2010-04-20 15:48:47 UTC
Size:
852 bytes
patch
obsolete
>commit eec06aa7b04e9761f540a66408e33eaf611a2775 >Author: Jim McDonough <jmcd@samba.org> >Date: Tue Apr 20 16:28:47 2010 -0400 > > Display an error on net conf import failures. > > When something goes wrong, such as a typo in a parameter > name, we'll now display the failure instead of just returning > with -1 and no message. > >diff --git a/source3/utils/net_conf.c b/source3/utils/net_conf.c >index 67e3c85..1fc07e1 100644 >--- a/source3/utils/net_conf.c >+++ b/source3/utils/net_conf.c >@@ -229,6 +229,9 @@ static WERROR import_process_service(struct net_context *c, > service->param_names[idx], > service->param_values[idx]); > if (!W_ERROR_IS_OK(werr)) { >+ d_printf("Error in section [%s], parameter \"%s\": %s\n", >+ service->name, service->param_names[idx], >+ win_errstr(werr)); > goto done; > } > }
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=5645">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Flags:
lars
:
review-
Actions:
View
Attachments on
bug 7378
:
5644
|
5645
|
5646
|
5647