Attachment 5305 Details for Bug 7122 – git am format patch for 3.5.0.

[patch] git am format patch for 3.5.0.

0001-Fix-bug-7122-Reading-a-large-browselist-fails-server.patch (text/plain), 2.30 KB, created by Jeremy Allison on 2010-02-09 17:17:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2010-02-09 17:17:49 UTC

Size: 2.30 KB

patch

obsolete

>From 8ddc977c1421a47bedba8d5494f7ae67692b772a Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Tue, 9 Feb 2010 15:14:38 -0800
>Subject: [PATCH] Fix bug #7122 - Reading a large browselist fails (server returns invalid values in subsequent SMBtrans replies)
>
>There are two problems:
>
>1). The server is off-by-one in the end of buffer space test.
>2). The server returns 0 in the totaldata (smb_vwv1) and totalparams (smb_vwv0)
>fields in the second and subsequent SMBtrans replies.
>
>This patch fixes both.
>
>Jeremy.
>---
> source3/smbd/ipc.c    |    3 +++
> source3/smbd/lanman.c |    6 +++---
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/source3/smbd/ipc.c b/source3/smbd/ipc.c
>index 12d4922..97b338a 100644
>--- a/source3/smbd/ipc.c
>+++ b/source3/smbd/ipc.c
>@@ -173,6 +173,9 @@ void send_trans_reply(connection_struct *conn,
> 					   rparam, tot_param_sent, this_lparam,
> 					   rdata, tot_data_sent, this_ldata);
> 
>+		SSVAL(req->outbuf,smb_vwv0,lparam);
>+		SSVAL(req->outbuf,smb_vwv1,ldata);
>+
> 		SSVAL(req->outbuf,smb_vwv3,this_lparam);
> 		SSVAL(req->outbuf,smb_vwv4,
> 		      smb_offset(smb_buf(req->outbuf)+1,req->outbuf));
>diff --git a/source3/smbd/lanman.c b/source3/smbd/lanman.c
>index eed0cd2..4df1cea 100644
>--- a/source3/smbd/lanman.c
>+++ b/source3/smbd/lanman.c
>@@ -1457,7 +1457,7 @@ static bool api_RNetServerEnum2(connection_struct *conn, uint16 vuid,
> 			DEBUG(4,("fill_srv_info[%d] %20s %8x %25s %15s\n",
> 				i, s->name, s->type, s->comment, s->domain));
> 
>-			if (data_len <= buf_len) {
>+			if (data_len < buf_len) {
> 				counted++;
> 				fixed_len += f_len;
> 				string_len += s_len;
>@@ -1663,7 +1663,7 @@ static bool api_RNetServerEnum3(connection_struct *conn, uint16 vuid,
> 			DEBUG(4,("fill_srv_info[%d] %20s %8x %25s %15s\n",
> 				i, s->name, s->type, s->comment, s->domain));
> 
>-			if (data_len <= buf_len) {
>+			if (data_len < buf_len) {
> 				counted++;
> 				fixed_len += f_len;
> 				string_len += s_len;
>@@ -2030,7 +2030,7 @@ static bool api_RNetShareEnum( connection_struct *conn, uint16 vuid,
> 		if( lp_browseable( i ) && lp_snum_ok( i ) && (strlen(servicename_dos) < 13)) {
> 			total++;
> 			data_len += fill_share_info(conn,i,uLevel,0,&f_len,0,&s_len,0);
>-			if (data_len <= buf_len) {
>+			if (data_len < buf_len) {
> 				counted++;
> 				fixed_len += f_len;
> 				string_len += s_len;
>-- 
>1.6.6
>

Flags:

metze: review+

Actions: View

Attachments on bug 7122: 5304 | 5305 | 5306 | 5307 | 5308 | 5309 | 5310