Attachment 5178 Details for Bug 7028 – Missing slash issue

[patch] Missing slash issue

patch4 (text/plain), 2.32 KB, created by Olivier Sessink on 2010-01-14 05:19:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Sessink

Created: 2010-01-14 05:19:43 UTC

Size: 2.32 KB

patch

obsolete

>--- vfs_scannedonly.c	2010-01-14 12:15:58.000000000 +0100
>+++ NEW_vfs_scannedonly.c	2010-01-14 12:18:28.000000000 +0100
>@@ -153,12 +153,6 @@
> 	return cachefile;
> }
> 
>-static char *path_plus_name(TALLOC_CTX *ctx, const char *base,
>-			    const char *filename)
>-{
>-	return talloc_asprintf(ctx, "%s%s", base,filename);
>-}
>-
> static char *construct_full_path(TALLOC_CTX *ctx, vfs_handle_struct * handle,
> 				 const char *somepath, bool ending_slash)
> {
>@@ -179,10 +173,10 @@
> 	}
> 	/* vfs_GetWd() seems to return a path with a slash */
> 	if (ending_slash) {
>-		return talloc_asprintf(ctx, "%s%s/",
>+		return talloc_asprintf(ctx, "%s/%s/",
> 				       vfs_GetWd(ctx, handle->conn),tmp);
> 	}
>-	return talloc_asprintf(ctx, "%s%s",
>+	return talloc_asprintf(ctx, "%s/%s",
> 			       vfs_GetWd(ctx, handle->conn),tmp);
> }
> 
>@@ -450,7 +444,7 @@
> 		while (dire) {
> 			char *fpath2;
> 			struct smb_filename *smb_fname2;
>-			fpath2 = path_plus_name(ctx,base_name, dire->d_name);
>+			fpath2 = talloc_asprintf(ctx, "%s%s", base_name,dire->d_name);
> 			DEBUG(SCANNEDONLY_DEBUG,
> 			      ("scannedonly_allow_access in loop, "
> 			       "found %s\n", fpath2));
>@@ -520,6 +514,8 @@
> 	} else {
> 		sDIR->base = name_w_ending_slash(sDIR, fname);
> 	}
>+	DEBUG(SCANNEDONLY_DEBUG,
>+			("scannedonly_opendir, fname=%s, base=%s\n",fname,sDIR->base));
> 	sDIR->DIR = DIRp;
> 	sDIR->notify_loop_done = 0;
> 	return (SMB_STRUCT_DIR *) sDIR;
>@@ -554,8 +550,7 @@
> 		       "skip to next entry\n", result->d_name));
> 		return scannedonly_readdir(handle, dirp, NULL);
> 	}
>-
>-	tmp = path_plus_name(ctx,sDIR->base, result->d_name);
>+	tmp = talloc_asprintf(ctx, "%s%s", sDIR->base, result->d_name);
> 	DEBUG(SCANNEDONLY_DEBUG,
> 	      ("scannedonly_readdir, check access to %s (sbuf=%p)\n",
> 	       tmp,sbuf));
>@@ -844,7 +839,7 @@
> 			}
> 			/* stat the file and see if it is a
> 			   special file */
>-			fullpath = path_plus_name(ctx,path_w_slash,
>+			fullpath = talloc_asprintf(ctx, "%s%s", path_w_slash,
> 						  dire->d_name);
> 			create_synthetic_smb_fname(ctx, fullpath,NULL,NULL,
> 						   &smb_fname);
>@@ -873,7 +868,7 @@
> 			if (ISDOT(dire->d_name) || ISDOTDOT(dire->d_name)) {
> 				continue;
> 			}
>-			fullpath = path_plus_name(ctx,path_w_slash,
>+			fullpath = talloc_asprintf(ctx, "%s%s", path_w_slash,
> 						  dire->d_name);
> 			create_synthetic_smb_fname(ctx, fullpath,NULL,NULL,
> 						   &smb_fname);

Actions: View

Attachments on bug 7028: 5171 | 5172 | 5173 | 5178 | 5185 | 5199