Attachment 3426 Details for Bug 5616 – proposed patch

[patch] proposed patch

0001-Attempt-to-fix-bug-5616.patch (text/plain), 1.65 KB, created by Volker Lendecke on 2008-07-28 11:07:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2008-07-28 11:07:05 UTC

Size: 1.65 KB

patch

obsolete

>From 1ea927a0664c036d47ceaa68a4de568c77845696 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@sernet.de>
>Date: Mon, 28 Jul 2008 17:52:35 +0200
>Subject: [PATCH] Attempt to fix bug 5616
>
>We were calculating the session key but did not return it to the caller...
>---
> source/rpc_client/cli_netlogon.c |   15 ++++++---------
> 1 files changed, 6 insertions(+), 9 deletions(-)
>
>diff --git a/source/rpc_client/cli_netlogon.c b/source/rpc_client/cli_netlogon.c
>index fcce18d..e96d724 100644
>--- a/source/rpc_client/cli_netlogon.c
>+++ b/source/rpc_client/cli_netlogon.c
>@@ -333,8 +333,6 @@ NTSTATUS rpccli_netlogon_sam_network_logon(struct rpc_pipe_client *cli,
> 	union netr_Validation validation;
> 	struct netr_ChallengeResponse lm;
> 	struct netr_ChallengeResponse nt;
>-	struct netr_UserSessionKey user_session_key;
>-	struct netr_LMSessionKey lmsesskey;
> 
> 	*info3 = NULL;
> 
>@@ -409,15 +407,14 @@ NTSTATUS rpccli_netlogon_sam_network_logon(struct rpc_pipe_client *cli,
> 		return result;
> 	}
> 
>-	user_session_key = validation.sam3->base.key;
>-	lmsesskey = validation.sam3->base.LMSessKey;
>-
>-	if (memcmp(zeros, user_session_key.key, 16) != 0) {
>-		SamOEMhash(user_session_key.key, cli->dc->sess_key, 16);
>+	if (memcmp(zeros, validation.sam3->base.key.key, 16) != 0) {
>+		SamOEMhash(validation.sam3->base.key.key,
>+			   cli->dc->sess_key, 16);
> 	}
> 
>-	if (memcmp(zeros, lmsesskey.key, 8) != 0) {
>-		SamOEMhash(lmsesskey.key, cli->dc->sess_key, 8);
>+	if (memcmp(zeros, validation.sam3->base.LMSessKey.key, 8) != 0) {
>+		SamOEMhash(validation.sam3->base.LMSessKey.key,
>+			   cli->dc->sess_key, 8);
> 	}
> 
> 	if (memcmp(zeros, ret_creds.cred.data, sizeof(ret_creds.cred.data)) != 0) {
>-- 
>1.5.2.2
>

Actions: View

Attachments on bug 5616: 3413 | 3420 | 3426 | 3436 | 3437