Attachment 2120 Details for Bug 4059 – fix

[patch] fix

4059.diff (text/plain), 1.36 KB, created by Volker Lendecke on 2006-09-02 16:47:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2006-09-02 16:47:17 UTC

Size: 1.36 KB

patch

obsolete

>Index: libsmb/ntlmssp.c
>===================================================================
>--- libsmb/ntlmssp.c	(Revision 18007)
>+++ libsmb/ntlmssp.c	(Revision 18008)
>@@ -813,16 +813,25 @@
> 		if (lm_session_key.data && lm_session_key.length >= 8) {
> 			if (ntlmssp_state->lm_resp.data && ntlmssp_state->lm_resp.length == 24) {
> 				session_key = data_blob_talloc(ntlmssp_state->mem_ctx, NULL, 16);
>+				if (session_key.data == NULL) {
>+					return NT_STATUS_NO_MEMORY;
>+				}
> 				SMBsesskeygen_lm_sess_key(lm_session_key.data, ntlmssp_state->lm_resp.data, 
> 							  session_key.data);
> 				DEBUG(10,("ntlmssp_server_auth: Created NTLM session key.\n"));
>-				dump_data_pw("LM session key:\n", session_key.data, session_key.length);
> 			} else {
>-				/* use the key unmodified - it's
>-				 * probably a NULL key from the guest
>-				 * login */
>-				session_key = lm_session_key;
>+				static const uint8 zeros[24] = { 0, };
>+				session_key = data_blob_talloc(
>+					ntlmssp_state->mem_ctx, NULL, 16);
>+				if (session_key.data == NULL) {
>+					return NT_STATUS_NO_MEMORY;
>+				}
>+				SMBsesskeygen_lm_sess_key(
>+					lm_session_key.data, zeros,
>+					session_key.data);
> 			}
>+			dump_data_pw("LM session key:\n", session_key.data,
>+				     session_key.length);
> 		} else {
> 			DEBUG(10,("ntlmssp_server_auth: Failed to create NTLM session key.\n"));
> 			session_key = data_blob(NULL, 0);

Actions: View

Attachments on bug 4059: 2108 | 2109 | 2120