The Samba-Bugzilla – Attachment 15780 Details for
Bug 14265
winbindd_getgrgid continues with a null SID and produces confusing log messages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patches for v4-11-test
tmp411.diff.txt (text/plain), 1.42 KB, created by
Stefan Metzmacher
on 2020-02-10 10:38:27 UTC
(
hide
)
Description:
Patches for v4-11-test
Filename:
MIME Type:
Creator:
Stefan Metzmacher
Created:
2020-02-10 10:38:27 UTC
Size:
1.42 KB
patch
obsolete
>From dbc1705af97c53d32754c7d22bd4aa0d0e1fc465 Mon Sep 17 00:00:00 2001 >From: Stefan Metzmacher <metze@samba.org> >Date: Wed, 22 Jan 2020 17:00:07 +0000 >Subject: [PATCH] winbindd: handling missing idmap in getgrgid() > >A similar hunk was added via commit >89f753c1fc824fef29aebb7d783ab7e09cd1f04e ("winbind: Use xids2sids in getpwuid"), >but it was missing in commit >e2dda192e7f8b65a5f02120be56cf0f07d03679f ("winbind: Use xids2sids in getgrgid") > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=14265 > >Signed-off-by: Stefan Metzmacher <metze@samba.org> >Reviewed-by: Andreas Schneider <asn@samba.org> > >Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> >Autobuild-Date(master): Wed Feb 5 17:56:58 UTC 2020 on sn-devel-184 > >(cherry picked from commit 4d0bda9467ac3f45f85f48a281cdb173ce1064eb) >--- > source3/winbindd/winbindd_getgrgid.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/source3/winbindd/winbindd_getgrgid.c b/source3/winbindd/winbindd_getgrgid.c >index aa99e6e25610..24d70161770a 100644 >--- a/source3/winbindd/winbindd_getgrgid.c >+++ b/source3/winbindd/winbindd_getgrgid.c >@@ -79,6 +79,10 @@ static void winbindd_getgrgid_gid2sid_done(struct tevent_req *subreq) > if (tevent_req_nterror(req, status)) { > return; > } >+ if (is_null_sid(state->sid)) { >+ tevent_req_nterror(req, NT_STATUS_NO_SUCH_GROUP); >+ return; >+ } > > subreq = wb_getgrsid_send(state, state->ev, state->sid, > lp_winbind_expand_groups()); >-- >2.17.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
asn
:
review+
Actions:
View
Attachments on
bug 14265
:
15779
| 15780 |
15781