Attachment 15295 Details for Bug 14017 – Patch for 4.9 and 4.10

[patch] Patch for 4.9 and 4.10

BZ14017.patch (text/plain), 1.37 KB, created by Martin Schwenke on 2019-07-08 12:26:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Schwenke

Created: 2019-07-08 12:26:54 UTC

Size: 1.37 KB

patch

obsolete

>From f3872517e5f9f713892815568f80cb7f514864f0 Mon Sep 17 00:00:00 2001
>From: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
>Date: Thu, 27 Jun 2019 20:12:25 +0000
>Subject: [PATCH] ctdb-config: depend on /etc/ctdb/nodes file
>
>CTDB should start as a disabled unit (systemd) in most of the
>distributions and, when trying to enable it for the first time, user
>should get an unconfigured, or similar, error.
>
>Depending on /etc/ctdb/nodes file will give a clear direction to final
>user on what is needed in order to get cluster up and running. It should
>work like previous ENABLED=NO variables in SySV like initialization
>scripts.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14017
>RN: ctdb.service should only start if /etc/ctdb/nodes is not empty
>Signed-off-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
>Reviewed-by: Martin Schwenke <martin@meltin.net>
>Reviewed-by: Amitay Isaacs <amitay@gmail.com>
>(cherry picked from commit c5803507df7def388edcd5b6cbfee30cd217b536)
>---
> ctdb/config/ctdb.service | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/ctdb/config/ctdb.service b/ctdb/config/ctdb.service
>index 675b3147417..fd81c38e26d 100644
>--- a/ctdb/config/ctdb.service
>+++ b/ctdb/config/ctdb.service
>@@ -2,6 +2,7 @@
> Description=CTDB
> Documentation=man:ctdbd(1) man:ctdb(7)
> After=network-online.target time-sync.target
>+ConditionFileNotEmpty=/etc/ctdb/nodes
> 
> [Service]
> Type=forking
>-- 
>2.20.1
>

Flags:

amitay: review+

Actions: View

Attachments on bug 14017: 15269 | 15295