Attachment 14234 Details for Bug 13437 – additional patch for heimdal

[patch] additional patch for heimdal

heimdal-patch.txt (text/plain), 2.94 KB, created by Guenther Deschner on 2018-06-14 14:35:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guenther Deschner

Created: 2018-06-14 14:35:13 UTC

Size: 2.94 KB

patch

obsolete

>From 7ddbf6035dfec6806536f99d0257245f70661363 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org>
>Date: Wed, 30 May 2018 09:27:49 +0200
>Subject: [PATCH] s4-heimdal: Fix the format-truncation errors.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>../source4/heimdal/lib/com_err/compile_et.c: In function âgenerate_hâ:
>../source4/heimdal/lib/com_err/compile_et.c:138:33: error: â%sâ directive output may be truncated writing up to 127 bytes into a region of size 126 [-Werror=format-truncation=]
>     snprintf(fn, sizeof(fn), "__%s__", hfn);
>                                 ^~     ~~~
>../source4/heimdal/lib/com_err/compile_et.c:138:5: note: âsnprintfâ output between 5 and 132 bytes into a destination of size 128
>     snprintf(fn, sizeof(fn), "__%s__", hfn);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../source4/heimdal/lib/com_err/compile_et.c: In function âmainâ:
>../source4/heimdal/lib/com_err/compile_et.c:234:35: error: â.hâ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
>     snprintf(hfn, sizeof(hfn), "%s.h", Basename);
>                                   ^~
>../source4/heimdal/lib/com_err/compile_et.c:234:5: note: âsnprintfâ output between 3 and 130 bytes into a destination of size 128
>     snprintf(hfn, sizeof(hfn), "%s.h", Basename);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../source4/heimdal/lib/com_err/compile_et.c:235:35: error: â.câ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
>     snprintf(cfn, sizeof(cfn), "%s.c", Basename);
>                                   ^~
>../source4/heimdal/lib/com_err/compile_et.c:235:5: note: âsnprintfâ output between 3 and 130 bytes into a destination of size 128
>     snprintf(cfn, sizeof(cfn), "%s.c", Basename);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>cc1: some warnings being treated as errors
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
>
>Guenther
>
>Signed-off-by: GÃ¼nther Deschner <gd@samba.org>
>Reviewed-by: Andreas Schneider <asn@samba.org>
>
>Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
>Autobuild-Date(master): Fri Jun  8 13:23:51 CEST 2018 on sn-devel-144
>---
> source4/heimdal/lib/com_err/compile_et.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/source4/heimdal/lib/com_err/compile_et.c b/source4/heimdal/lib/com_err/compile_et.c
>index c72abdecc86..5841ecaabaf 100644
>--- a/source4/heimdal/lib/com_err/compile_et.c
>+++ b/source4/heimdal/lib/com_err/compile_et.c
>@@ -60,8 +60,8 @@ extern int yydebug = 1;
> #endif
> 
> char *filename;
>-char hfn[128];
>-char cfn[128];
>+char hfn[130];
>+char cfn[130];
> 
> struct error_code *codes = NULL;
> 
>@@ -128,7 +128,7 @@ static int
> generate_h(void)
> {
>     struct error_code *ec;
>-    char fn[128];
>+    char fn[134];
>     FILE *h_file = fopen(hfn, "w");
>     char *p;
> 
>-- 
>2.17.1
>

Flags:

asn: review+

Actions: View

Attachments on bug 13437: 14214 | 14216 | 14233 | 14234 | 14244 | 14248 | 14249 | 14250