The Samba-Bugzilla – Attachment 12159 Details for
Bug 11947
lib/replace/snprintf.c:fmtint -- buffer too small (convert[20])
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
suggested fix
snprintf.patch (text/plain), 839 bytes, created by
Lorinczy Zsigmond
on 2016-06-02 10:26:30 UTC
(
hide
)
Description:
suggested fix
Filename:
MIME Type:
Creator:
Lorinczy Zsigmond
Created:
2016-06-02 10:26:30 UTC
Size:
839 bytes
patch
obsolete
>--- snprintf.~c 2016-01-26 12:45:46.000000000 +0100 >+++ snprintf.c 2016-06-02 12:12:12.000000000 +0200 >@@ -804,7 +804,7 @@ > { > int signvalue = 0; > unsigned LLONG uvalue; >- char convert[20]; >+ char convert[22+1];/* 64-bit value in octal: 22 digits + \0 */ > int place = 0; > int spadlen = 0; /* amount to space pad */ > int zpadlen = 0; /* amount to zero pad */ >@@ -834,8 +834,8 @@ > (caps? "0123456789ABCDEF":"0123456789abcdef") > [uvalue % (unsigned)base ]; > uvalue = (uvalue / (unsigned)base ); >- } while(uvalue && (place < 20)); >- if (place == 20) place--; >+ } while(uvalue && (place < sizeof convert)); >+ if (place == sizeof convert) place--; > convert[place] = 0; > > zpadlen = max - place;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=12159">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 11947
:
12159
|
12160
|
12161