The Samba-Bugzilla – Bug 11947
lib/replace/snprintf.c:fmtint -- buffer too small (convert)
Last modified: 2016-07-12 19:26:30 UTC
Created attachment 12159 [details]
On AIX platform, I got different problems using smbd that seemed to be related with OpLocks
With some debugging, I could track it down to 'messaging_dgm_lockfile_create': the value written into file /var/run/sambalocks/msg.lock/PID is sometimes one digit shorter than the actual value of 'unique': the first digits get losts, eg:
With some more debugging, I found out that 'smbd' uses an own version of 'snprintf' that has a problem with large numbers; to be more precise buffer 'convert' in function 'fmtint' of 'lib/replace/snprintf.c' is too small; so the most signification digit gets lost.
I'm attaching a trivial patch to fix the problem (the length of buffer becomes to 22 to support octal values too).
Yours: Lorinczy Zsigmond
Created attachment 12160 [details]
Correction of the previous (spaces vs TABs)
Looks correct to me. I'll propose to master and then get it back-ported. Thanks a *lot* !
Created attachment 12161 [details]
git-am fix for 4.4.next, 4.3.next.
Cherry-picked from master.
Reassigning to Karolin for inclusion in 4.3 and 4.4.
(In reply to Ralph Böhme from comment #4)
Pushed to autobuild-v4-[4|3]-test.
(In reply to Karolin Seeger from comment #5)
Pushed to both branches.
Closing out bug report.
I certainly don't want to seem pushy, but could you please merge this patch into the next 4.4.x release?
Thank you very much.
This has already been merged by Karolin and will be in the next non-security 4.4.x release.