The Samba-Bugzilla – Attachment 11480 Details for
Bug 11316
tevent_fd needs to be destroyed before closing the fd
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch for ctdbd_connection_destructor in master
tmp.diff.txt (text/plain), 886 bytes, created by
Stefan Metzmacher
on 2015-10-05 23:08:41 UTC
(
hide
)
Description:
Patch for ctdbd_connection_destructor in master
Filename:
MIME Type:
Creator:
Stefan Metzmacher
Created:
2015-10-05 23:08:41 UTC
Size:
886 bytes
patch
obsolete
>From 6dcd2c1acb75fcbedc1b124520e316664a284b8f Mon Sep 17 00:00:00 2001 >From: Stefan Metzmacher <metze@samba.org> >Date: Mon, 5 Oct 2015 15:57:42 +0200 >Subject: [PATCH] s3:ctdbd_conn: make sure we destroy tevent_fd before closing > the socket > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316 > >Signed-off-by: Stefan Metzmacher <metze@samba.org> >--- > source3/lib/ctdbd_conn.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/source3/lib/ctdbd_conn.c b/source3/lib/ctdbd_conn.c >index 1acce12..c19b6e5 100644 >--- a/source3/lib/ctdbd_conn.c >+++ b/source3/lib/ctdbd_conn.c >@@ -421,7 +421,11 @@ static int ctdb_read_req(struct ctdbd_connection *conn, uint32_t reqid, > > static int ctdbd_connection_destructor(struct ctdbd_connection *c) > { >- close(c->fd); >+ TALLOC_FREE(c->fde); >+ if (c->fd != -1) { >+ close(c->fd); >+ c->fd = -1; >+ } > return 0; > } > /* >-- >1.9.1 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=11480">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Flags:
gd
:
review+
vl
:
review+
Actions:
View
Attachments on
bug 11316
:
11155
|
11157
|
11161
|
11164
|
11344
|
11345
|
11347
|
11348
| 11480 |
11482
|
11483