Attachment 11477 Details for Bug 11541 – add an option to disable slp

[patch] add an option to disable slp

slp.diff (text/plain), 17.54 KB, created by Vitezslav Cizek on 2015-10-05 14:59:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vitezslav Cizek

Created: 2015-10-05 14:59:28 UTC

Size: 17.54 KB

patch

obsolete

>This adds Service Location Protocol support.
>
>To use this patch, run these commands for a successful build:
>
>    patch -p1 <patches/slp.diff
>    ./prepare-source
>    ./configure --enable-slp
>    make
>
>TODO: the configure changes should abort if the user requests --enable-slp
>and we can't honor that request.
>
>based-on: bb853b32055a16e983267c6f5b8244aac311fdf9
>diff --git a/Makefile.in b/Makefile.in
>--- a/Makefile.in
>+++ b/Makefile.in
>@@ -14,6 +14,8 @@ CFLAGS=@CFLAGS@
> CPPFLAGS=@CPPFLAGS@
> EXEEXT=@EXEEXT@
> LDFLAGS=@LDFLAGS@
>+LIBSLP=@LIBSLP@
>+SLPOBJ=@SLPOBJ@
> LIBOBJDIR=lib/
> 
> INSTALLCMD=@INSTALL@
>@@ -41,7 +43,7 @@ OBJS1=flist.o rsync.o generator.o receiver.o cleanup.o sender.o exclude.o \
> OBJS2=options.o io.o compat.o hlink.o token.o uidlist.o socket.o hashtable.o \
> 	fileio.o batch.o clientname.o chmod.o acls.o xattrs.o
> OBJS3=progress.o pipe.o
>-DAEMON_OBJ = params.o loadparm.o clientserver.o access.o connection.o authenticate.o
>+DAEMON_OBJ = params.o loadparm.o clientserver.o access.o connection.o authenticate.o $(SLPOBJ)
> popt_OBJS=popt/findme.o  popt/popt.o  popt/poptconfig.o \
> 	popt/popthelp.o popt/poptparse.o
> OBJS=$(OBJS1) $(OBJS2) $(OBJS3) $(DAEMON_OBJ) $(LIBOBJ) @BUILD_ZLIB@ @BUILD_POPT@
>@@ -91,7 +93,7 @@ install-strip:
> 	$(MAKE) INSTALL_STRIP='-s' install
> 
> rsync$(EXEEXT): $(OBJS)
>-	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(OBJS) $(LIBS)
>+	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(OBJS) $(LIBS) $(LIBSLP)
> 
> $(OBJS): $(HEADERS)
> $(CHECK_OBJS): $(HEADERS)
>diff --git a/clientserver.c b/clientserver.c
>--- a/clientserver.c
>+++ b/clientserver.c
>@@ -1193,6 +1193,13 @@ int daemon_main(void)
> 	 * address too.  In fact, why not just do getnameinfo on the
> 	 * local address??? */
> 
>+#ifdef HAVE_LIBSLP
>+	if (lp_use_slp() && register_services()) {
>+		rprintf(FINFO,
>+		    "Couldn't register with service discovery protocol, continuing anyway\n");
>+	}
>+#endif
>+
> 	start_accept_loop(rsync_port, start_daemon);
> 	return -1;
> }
>diff --git a/configure.ac b/configure.ac
>--- a/configure.ac
>+++ b/configure.ac
>@@ -721,6 +721,29 @@ if test $rsync_cv_can_hardlink_special = yes; then
>     AC_DEFINE(CAN_HARDLINK_SPECIAL, 1, [Define to 1 if link() can hard-link special files.])
> fi
> 
>+AC_ARG_ENABLE(slp, [  --disable-slp           turn off SLP support, defaults to on])
>+AC_ARG_WITH(openslp-libs, [  --with-openslp-libs     set directory for OpenSLP library],
>+    LDFLAGS="-L$withval $LDFLAGS"
>+    DSOFLAGS="-L$withval $DSOFLAGS",)
>+AC_ARG_WITH(openslp-includes, [  --with-openslp-includes set directory for OpenSLP includes],
>+    CFLAGS="-I$withval $CFLAGS"
>+    CXXFLAGS="-I$withval $CXXFLAGS"
>+    CPPFLAGS="-I$withval $CPPFLAGS",)
>+
>+LIBSLP=""
>+SLPOBJ=""
>+
>+if test x$enable_slp != xno; then
>+    AC_CHECK_HEADER(slp.h,
>+        AC_CHECK_LIB(slp, SLPOpen,
>+	    AC_DEFINE(HAVE_LIBSLP, 1, [Define to 1 for SLP support])
>+	    SLPOBJ="srvreg.o srvloc.o"
>+            LIBSLP="-lslp"))
>+fi
>+
>+AC_SUBST(LIBSLP)
>+AC_SUBST(SLPOBJ)
>+
> AC_CACHE_CHECK([for working socketpair],rsync_cv_HAVE_SOCKETPAIR,[
> AC_RUN_IFELSE([AC_LANG_SOURCE([[
> #include <sys/types.h>
>diff --git a/loadparm.c b/loadparm.c
>--- a/loadparm.c
>+++ b/loadparm.c
>@@ -99,6 +99,10 @@ typedef struct {
> 
> 	int listen_backlog;
> 	int rsync_port;
>+#ifdef HAVE_LIBSLP
>+	int slp_refresh;
>+	BOOL use_slp;
>+#endif
> } global_vars;
> 
> /* This structure describes a single section.  Their order must match the
>@@ -178,6 +182,10 @@ static const all_vars Defaults = {
> 
>  /* listen_backlog; */		5,
>  /* rsync_port; */		0,
>+#ifdef HAVE_LIBSLP
>+ /* slp_refresh; */		0,
>+ /* use_slp; */			True,
>+#endif
>  },
> 
>  /* ==== local_vars ==== */
>@@ -317,6 +325,10 @@ static struct parm_struct parm_table[] =
>  {"motd file",         P_STRING, P_GLOBAL,&Vars.g.motd_file,           NULL,0},
>  {"pid file",          P_STRING, P_GLOBAL,&Vars.g.pid_file,            NULL,0},
>  {"port",              P_INTEGER,P_GLOBAL,&Vars.g.rsync_port,          NULL,0},
>+#ifdef HAVE_LIBSLP
>+ {"slp refresh",       P_INTEGER,P_GLOBAL,&Vars.g.slp_refresh,         NULL,0},
>+ {"use slp",           P_BOOL,   P_GLOBAL,&Vars.g.use_slp,             NULL,0},
>+#endif
>  {"socket options",    P_STRING, P_GLOBAL,&Vars.g.socket_options,      NULL,0},
> 
>  {"auth users",        P_STRING, P_LOCAL, &Vars.l.auth_users,          NULL,0},
>@@ -450,6 +462,10 @@ FN_GLOBAL_STRING(lp_socket_options, &Vars.g.socket_options)
> 
> FN_GLOBAL_INTEGER(lp_listen_backlog, &Vars.g.listen_backlog)
> FN_GLOBAL_INTEGER(lp_rsync_port, &Vars.g.rsync_port)
>+#ifdef HAVE_LIBSLP
>+FN_GLOBAL_INTEGER(lp_slp_refresh, &Vars.g.slp_refresh)
>+FN_GLOBAL_BOOL(lp_use_slp, &Vars.g.use_slp)
>+#endif
> 
> FN_LOCAL_STRING(lp_auth_users, auth_users)
> FN_LOCAL_STRING(lp_charset, charset)
>diff --git a/main.c b/main.c
>--- a/main.c
>+++ b/main.c
>@@ -1259,6 +1259,23 @@ static int start_client(int argc, char *argv[])
> 
> 	if (!read_batch) { /* for read_batch, NO source is specified */
> 		char *path = check_for_hostspec(argv[0], &shell_machine, &rsync_port);
>+
>+		if (shell_machine && !shell_machine[0]) {
>+#ifdef HAVE_LIBSLP
>+			/* User entered just rsync:// URI */
>+			if (lp_use_slp()) {
>+				print_service_list();
>+				exit_cleanup(0);
>+			} else {
>+				rprintf(FINFO, "SLP is disabled, cannot browse\n");
>+				exit_cleanup(RERR_SYNTAX);
>+			}
>+#else /* No SLP, die here */
>+			rprintf(FINFO, "No SLP support, cannot browse\n");
>+			exit_cleanup(RERR_SYNTAX);
>+#endif
>+		}
>+
> 		if (path) { /* source is remote */
> 			char *dummy_host;
> 			int dummy_port = 0;
>diff --git a/options.c b/options.c
>--- a/options.c
>+++ b/options.c
>@@ -574,6 +574,7 @@ static void print_rsync_version(enum logcode f)
> 	char const *links = "no ";
> 	char const *iconv = "no ";
> 	char const *ipv6 = "no ";
>+	char const *slp = "no ";
> 	STRUCT_STAT *dumstat;
> 
> #if SUBPROTOCOL_VERSION != 0
>@@ -610,6 +611,9 @@ static void print_rsync_version(enum logcode f)
> #ifdef CAN_SET_SYMLINK_TIMES
> 	symtimes = "";
> #endif
>+#if HAVE_LIBSLP
>+	slp = "";
>+#endif
> 
> 	rprintf(f, "%s  version %s  protocol version %d%s\n",
> 		RSYNC_NAME, RSYNC_VERSION, PROTOCOL_VERSION, subprotocol);
>@@ -623,8 +627,8 @@ static void print_rsync_version(enum logcode f)
> 		(int)(sizeof (int64) * 8));
> 	rprintf(f, "    %ssocketpairs, %shardlinks, %ssymlinks, %sIPv6, batchfiles, %sinplace,\n",
> 		got_socketpair, hardlinks, links, ipv6, have_inplace);
>-	rprintf(f, "    %sappend, %sACLs, %sxattrs, %siconv, %ssymtimes, %sprealloc\n",
>-		have_inplace, acls, xattrs, iconv, symtimes, prealloc);
>+	rprintf(f, "    %sappend, %sACLs, %sxattrs, %siconv, %ssymtimes, %sprealloc, %sSLP\n",
>+		have_inplace, acls, xattrs, iconv, symtimes, prealloc, slp);
> 
> #ifdef MAINTAINER_MODE
> 	rprintf(f, "Panic Action: \"%s\"\n", get_panic_action());
>diff --git a/rsync.h b/rsync.h
>--- a/rsync.h
>+++ b/rsync.h
>@@ -204,6 +204,10 @@
> #define SIGNIFICANT_ITEM_FLAGS (~(\
> 	ITEM_BASIS_TYPE_FOLLOWS | ITEM_XNAME_FOLLOWS | ITEM_LOCAL_CHANGE))
> 
>+/* this is the minimum we'll use, irrespective of config setting */
>+/* definately don't set to less than about 30 seconds */
>+#define SLP_MIN_TIMEOUT 120
>+
> #define CFN_KEEP_DOT_DIRS (1<<0)
> #define CFN_KEEP_TRAILING_SLASH (1<<1)
> #define CFN_DROP_TRAILING_DOT_DIR (1<<2)
>diff --git a/rsync.yo b/rsync.yo
>--- a/rsync.yo
>+++ b/rsync.yo
>@@ -151,7 +151,12 @@ particular rsync daemon by leaving off the module name:
> 
> quote(tt(rsync somehost.mydomain.com::))
> 
>-See the following section for more details.
>+And, if Service Location Protocol is available, the following will list the
>+available rsync servers:
>+
>+quote(tt(rsync rsync://))
>+
>+See the following section for even more usage details.
> 
> manpagesection(ADVANCED USAGE)
> 
>diff --git a/rsyncd.conf b/rsyncd.conf
>new file mode 100644
>--- /dev/null
>+++ b/rsyncd.conf
>@@ -0,0 +1 @@
>+slp refresh = 3600
>diff --git a/rsyncd.conf.yo b/rsyncd.conf.yo
>--- a/rsyncd.conf.yo
>+++ b/rsyncd.conf.yo
>@@ -126,6 +126,19 @@ via the bf(--sockopts) command-line option.
> dit(bf(listen backlog)) You can override the default backlog value when the
> daemon listens for connections.  It defaults to 5.
> 
>+dit(bf(use slp)) This parameter is used to determine if the module names are
>+advertised via slp.  The default is for this to be enabled, which will
>+advertise your public modules.
>+
>+dit(bf(slp refresh)) This parameter is used to determine how long service
>+advertisements are valid (measured in seconds), and is only applicable if
>+you have Service Location Protocol support compiled in. If this is
>+not set or is set to zero, then service advertisements never time out. If
>+this is set to less than 120 seconds, then 120 seconds is used. If it is
>+set to more than 65535, then 65535 is used (which is a limitation of SLP).
>+Using 3600 (one hour) is a good number if you tend to change your
>+configuration.
>+
> enddit()
> 
> manpagesection(MODULE PARAMETERS)
>@@ -857,6 +870,7 @@ use chroot = yes
> max connections = 4
> syslog facility = local5
> pid file = /var/run/rsyncd.pid
>+slp refresh = 3600
> 
> [ftp]
>         path = /var/ftp/./pub
>diff --git a/socket.c b/socket.c
>--- a/socket.c
>+++ b/socket.c
>@@ -544,6 +544,16 @@ void start_accept_loop(int port, int (*fn)(int, int))
> {
> 	fd_set deffds;
> 	int *sp, maxfd, i;
>+#ifdef HAVE_LIBSLP
>+	time_t next_slp_refresh;
>+	short slp_timeout = lp_use_slp() ? lp_slp_refresh() : 0;
>+	if (slp_timeout) {
>+		if (slp_timeout < SLP_MIN_TIMEOUT)
>+			slp_timeout = SLP_MIN_TIMEOUT;
>+		/* re-register before slp times out */
>+		slp_timeout -= 15;
>+	}
>+#endif
> 
> #ifdef HAVE_SIGACTION
> 	sigact.sa_flags = SA_NOCLDSTOP;
>@@ -572,14 +582,25 @@ void start_accept_loop(int port, int (*fn)(int, int))
> 			maxfd = sp[i];
> 	}
> 
>+#ifdef HAVE_LIBSLP
>+	next_slp_refresh = time(NULL) + slp_timeout;
>+#endif
>+
> 	/* now accept incoming connections - forking a new process
> 	 * for each incoming connection */
> 	while (1) {
> 		fd_set fds;
> 		pid_t pid;
> 		int fd;
>+		int sel_ret;
> 		struct sockaddr_storage addr;
> 		socklen_t addrlen = sizeof addr;
>+#ifdef HAVE_LIBSLP
>+		struct timeval slp_tv;
>+
>+		slp_tv.tv_sec = 10;
>+		slp_tv.tv_usec = 0;
>+#endif
> 
> 		/* close log file before the potentially very long select so
> 		 * file can be trimmed by another process instead of growing
>@@ -592,7 +613,18 @@ void start_accept_loop(int port, int (*fn)(int, int))
> 		fds = deffds;
> #endif
> 
>-		if (select(maxfd + 1, &fds, NULL, NULL, NULL) < 1)
>+#ifdef HAVE_LIBSLP
>+		sel_ret = select(maxfd + 1, &fds, NULL, NULL,
>+				 slp_timeout ? &slp_tv : NULL);
>+		if (sel_ret == 0 && slp_timeout && time(NULL) > next_slp_refresh) {
>+			rprintf(FINFO, "Service registration expired, refreshing it\n");
>+			register_services();
>+			next_slp_refresh = time(NULL) + slp_timeout;
>+		}
>+#else
>+		sel_ret = select(maxfd + 1, &fds, NULL, NULL, NULL);
>+#endif
>+		if (sel_ret < 1)
> 			continue;
> 
> 		for (i = 0, fd = -1; sp[i] >= 0; i++) {
>diff --git a/srvloc.c b/srvloc.c
>new file mode 100644
>--- /dev/null
>+++ b/srvloc.c
>@@ -0,0 +1,103 @@
>+/* -*- c-file-style: "linux"; -*-
>+
>+   Copyright (C) 2002 by Brad Hards <bradh@frogmouth.net>
>+
>+   This program is free software; you can redistribute it and/or modify
>+   it under the terms of the GNU General Public License as published by
>+   the Free Software Foundation; either version 2 of the License, or
>+   (at your option) any later version.
>+
>+   This program is distributed in the hope that it will be useful,
>+   but WITHOUT ANY WARRANTY; without even the implied warranty of
>+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>+   GNU General Public License for more details.
>+
>+   You should have received a copy of the GNU General Public License
>+   along with this program; if not, write to the Free Software
>+   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>+*/
>+
>+/* This file implements the service location functionality */
>+/* Basically, it uses normal Service Location Protocol API */
>+
>+/* It is really a cheap hack - just to show how it might work
>+   in a real application.
>+*/
>+
>+#include "rsync.h"
>+
>+#include <slp.h>
>+#include <stdio.h>
>+#include <string.h>
>+
>+/* This one just prints out the attributes */
>+static SLPBoolean getAttrCallback(UNUSED(SLPHandle hslp), const char *attrlist,
>+				  SLPError errcode, UNUSED(void *cookie))
>+{
>+	char *cleanstr;
>+
>+	if (errcode == SLP_OK) {
>+		if (!strcmp(attrlist, "(comment=)"))
>+			rprintf(FINFO, "\t(No description)\n");
>+		else {
>+			cleanstr = strrchr(attrlist, ')') ;
>+			*cleanstr = ' '; /* remove last ')' */
>+			rprintf(FINFO, "\t%s\n", strchr(attrlist, '=') + 1);
>+		}
>+	}
>+	return SLP_FALSE;
>+}
>+
>+static SLPBoolean getSLPSrvURLCallback(UNUSED(SLPHandle hslp),
>+			const char *srvurl, UNUSED(unsigned short lifetime),
>+			SLPError errcode, void *cookie)
>+{
>+	SLPError    result;
>+	SLPHandle   attrhslp;
>+
>+	if (errcode == SLP_OK) {
>+		/* chop service: off the front */
>+		rprintf(FINFO, "  %s  ", (strchr(srvurl, ':') + 1));
>+		/* check for any attributes */
>+		if (SLPOpen("en", SLP_FALSE,&attrhslp) == SLP_OK) {
>+			result = SLPFindAttrs(attrhslp, srvurl,
>+					      "", /* return all attributes */
>+					      "", /* use configured scopes */
>+					      getAttrCallback, NULL);
>+			if (result != SLP_OK) {
>+				rprintf(FERROR, "errorcode: %i\n",result);
>+			}
>+			SLPClose(attrhslp);
>+		}
>+		*(SLPError*)cookie = SLP_OK;
>+	} else
>+		*(SLPError*)cookie = errcode;
>+
>+	/* Return SLP_TRUE because we want to be called again
>+	 * if more services were found. */
>+
>+	return SLP_TRUE;
>+}
>+
>+int print_service_list(void)
>+{
>+	SLPError err;
>+	SLPError callbackerr;
>+	SLPHandle hslp;
>+
>+	err = SLPOpen("en",SLP_FALSE,&hslp);
>+	if (err != SLP_OK) {
>+		rprintf(FERROR, "Error opening slp handle %i\n", err);
>+		return err;
>+	}
>+
>+	SLPFindSrvs(hslp, "rsync",
>+		    0, /* use configured scopes */
>+		    0, /* no attr filter        */
>+		    getSLPSrvURLCallback, &callbackerr);
>+
>+	/* Now that we're done using slp, close the slp handle */
>+	SLPClose(hslp);
>+
>+	return 0;
>+}
>diff --git a/srvreg.c b/srvreg.c
>new file mode 100644
>--- /dev/null
>+++ b/srvreg.c
>@@ -0,0 +1,128 @@
>+/* -*- c-file-style: "linux"; -*-
>+
>+   Copyright (C) 2002 by Brad Hards <bradh@frogmouth.net>
>+
>+   This program is free software; you can redistribute it and/or modify
>+   it under the terms of the GNU General Public License as published by
>+   the Free Software Foundation; either version 2 of the License, or
>+   (at your option) any later version.
>+
>+   This program is distributed in the hope that it will be useful,
>+   but WITHOUT ANY WARRANTY; without even the implied warranty of
>+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>+   GNU General Public License for more details.
>+
>+   You should have received a copy of the GNU General Public License
>+   along with this program; if not, write to the Free Software
>+   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>+*/
>+
>+/* This file implements the service registration functionality */
>+
>+/* Basically, it uses normal Service Location Protocol API */
>+
>+#include "rsync.h"
>+#include "slp.h"
>+#include "netdb.h"
>+
>+extern int rsync_port;
>+
>+static void slp_callback(UNUSED(SLPHandle hslp), SLPError errcode, void *cookie)
>+{
>+	/* return the error code in the cookie */
>+	*(SLPError*)cookie = errcode;
>+
>+	/* You could do something else here like print out
>+	 * the errcode, etc.  Remember, as a general rule,
>+	 * do not try to do too much in a callback because
>+	 * it is being executed by the same thread that is
>+	 * reading slp packets from the wire. */
>+}
>+
>+int register_services(void)
>+{
>+	SLPError err, callbackerr;
>+	SLPHandle hslp;
>+	int n;
>+	int i;
>+	char srv[120];
>+	char attr[120];
>+	char localhost[256];
>+	extern char *config_file;
>+	short timeout;
>+	struct addrinfo aih, *ai = 0;
>+
>+	if (!lp_load(config_file, 0)) {
>+		exit_cleanup(RERR_SYNTAX);
>+	}
>+
>+	n = lp_num_modules();
>+
>+	if (0 == lp_slp_refresh())
>+		timeout = SLP_LIFETIME_MAXIMUM; /* don't expire, ever */
>+	else if (SLP_MIN_TIMEOUT > lp_slp_refresh())
>+		timeout = SLP_MIN_TIMEOUT; /* use a reasonable minimum */
>+	else if (SLP_LIFETIME_MAXIMUM <= lp_slp_refresh())
>+		timeout = (SLP_LIFETIME_MAXIMUM - 1); /* as long as possible */
>+	else
>+		timeout = lp_slp_refresh();
>+
>+	rprintf(FINFO, "rsyncd registering %d service%s with slpd for %d seconds:\n", n, ((n==1)? "":"s"), timeout);
>+	err = SLPOpen("en",SLP_FALSE,&hslp);
>+	if (err != SLP_OK) {
>+		rprintf(FINFO, "Error opening slp handle %i\n",err);
>+		return err;
>+	}
>+	if (gethostname(localhost, sizeof localhost)) {
>+	       rprintf(FINFO, "Could not get hostname: %s\n", strerror(errno));
>+	       return err;
>+	}
>+	memset(&aih, 0, sizeof aih);
>+	aih.ai_family = PF_UNSPEC;
>+	aih.ai_flags = AI_CANONNAME;
>+	if (0 != (err = getaddrinfo(localhost, 0, &aih, &ai)) || !ai) {
>+	       rprintf(FINFO, "Could not resolve hostname: %s\n", gai_strerror(err));
>+	       return err;
>+	}
>+	/* Register each service with SLP */
>+	for (i = 0; i < n; i++) {
>+		if (!lp_list(i))
>+			continue;
>+
>+		snprintf(srv, sizeof srv, "service:rsync://%s:%d/%s",
>+			 ai->ai_canonname,
>+			 rsync_port,
>+			 lp_name(i));
>+		rprintf(FINFO, "    %s\n", srv);
>+		if (lp_comment(i)) {
>+			snprintf(attr, sizeof attr, "(comment=%s)",
>+				 lp_comment(i));
>+		}
>+		err = SLPReg(hslp,
>+			     srv, /* service to register */
>+			     timeout,
>+			     0,  /* this is ignored */
>+			     attr, /* attributes */
>+			     SLP_TRUE, /* new registration - don't change this */
>+			     slp_callback, /* callback */
>+			     &callbackerr);
>+
>+		/* err may contain an error code that occurred as the slp library
>+		 * _prepared_ to make the call. */
>+		if (err != SLP_OK || callbackerr != SLP_OK)
>+			rprintf(FINFO, "Error registering service with slp %i\n", err);
>+
>+		/* callbackerr may contain an error code (that was assigned through
>+		 * the callback cookie) that occurred as slp packets were sent on
>+		 * the wire. */
>+		if (callbackerr != SLP_OK)
>+			rprintf(FINFO, "Error registering service with slp %i\n",callbackerr);
>+	}
>+
>+	/* Now that we're done using slp, close the slp handle */
>+	freeaddrinfo(ai);
>+	SLPClose(hslp);
>+
>+	/* refresh is done in main select loop */
>+	return 0;
>+}

Actions: View

Attachments on bug 11541: 11477